gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Fix income summary totals (#759)

Browse Source
This commit was merged in pull request #759.
This commit is contained in:
Zach Gollwitzer
2024-05-17 17:50:49 -04:00
committed by GitHub
parent 0d0f766ca1
commit ac46c0c5a9
2 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/transaction.rb
View File

@@ -9,8 +9,8 @@ class Transaction < ApplicationRecord
monetize :amount
scope :inflows, -> { where("amount > 0") }
scope :outflows, -> { where("amount < 0") }
scope :inflows, -> { where("amount <= 0") }
scope :outflows, -> { where("amount > 0") }
scope :active, -> { where(excluded: false) }
scope :with_converted_amount, ->(currency = Current.family.currency) {
# Join with exchange rates to convert the amount to the given currency

10
test/models/transaction_test.rb
View File

@@ -1,4 +1,14 @@
require "test_helper"
class TransactionTest < ActiveSupport::TestCase
# See: https://github.com/maybe-finance/maybe/wiki/vision#signage-of-money
test "negative amounts are inflows, positive amounts are outflows to an account" do
inflow_transaction = transactions(:checking_four)
outflow_transaction = transactions(:checking_five)
assert inflow_transaction.amount < 0
assert outflow_transaction.amount >= 0
assert Transaction.inflows.include? inflow_transaction
assert Transaction.outflows.include? outflow_transaction
end
end