gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Fix form labels #1004

Merged
tonyvince merged 4 commits from fix-#1001 into main 2024-07-22 22:04:55 +08:00
Conversation 3 Commits 4 Files Changed 1 +5 -2
tonyvince commented 2024-07-21 03:20:58 +08:00 (Migrated from github.com)
Copy Link

Fix #1001

Fix #1001
🎉 1
zachgoll (Migrated from github.com) reviewed 2024-07-22 21:29:45 +08:00
zachgoll (Migrated from github.com) left a comment
Copy Link

Really nice solution here!

I like this as our fallback, but I think we need to provide an explicit label in order to leverage I18n translations correct? Or is there a more automated way to handle that via model translations that you know of?

Really nice solution here! I like this as our fallback, but I think we need to provide an explicit label in order to leverage I18n translations correct? Or is there a more automated way to handle that via model translations that you know of?
tonyvince commented 2024-07-22 21:52:47 +08:00 (Migrated from github.com)
Copy Link

I think we need to provide an explicit label in order to leverage I18n translations correct? Or is there a more automated way to handle that via model translations that you know of?

Not sure I understand what you mean fully but label: true as we have here is the automaded way of handling them via model translation. A custom label like label: t(".email") will still work with this solution

> I think we need to provide an explicit label in order to leverage I18n translations correct? Or is there a more automated way to handle that via model translations that you know of? Not sure I understand what you mean fully but `label: true` as we have [here](https://github.com/maybe-finance/maybe/blob/main/app/views/accounts/accountables/_investment.html.erb#L1) is the [automaded](https://api.rubyonrails.org/v7.1.3.4/classes/ActionView/Helpers/FormHelper.html#method-i-label) way of handling them via model translation. A custom label like `label: t(".email")` will still work with this solution
zachgoll commented 2024-07-22 22:04:50 +08:00 (Migrated from github.com)
Copy Link

@tonyvince my bad, I see what you mean now! I had missed that piece of logic when updating the forms.

@tonyvince my bad, I see what you mean now! I had missed that piece of logic when updating the forms.
Sign in to join this conversation.
Reviewers
No Reviewers
zachgoll
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#1004
Delete Branch "fix-#1001"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?