gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Fetch exchange rates in bulk from synth #1069

Merged
tonyvince merged 6 commits from 1047-make-bulk-calls-to-synth-api into main 2024-08-09 22:57:33 +08:00
Conversation 4 Commits 6 Files Changed 6 +297 -11
tonyvince commented 2024-08-08 20:16:15 +08:00 (Migrated from github.com)
Copy Link

Fix #1047

Fix #1047
zachgoll (Migrated from github.com) reviewed 2024-08-09 04:40:09 +08:00
zachgoll (Migrated from github.com) left a comment
Copy Link

Awesome work here!

Awesome work here!
app/models/exchange_rate/provided.rb
@@ -15,0 +30,4 @@
end
else
[]
end
zachgoll (Migrated from github.com) commented 2024-08-09 04:39:36 +08:00
Copy Link

I think this should fix #1037 as well correct?

I think this should fix #1037 as well correct?
app/models/provider/synth.rb
@@ -57,12 +57,40 @@ class Provider::Synth
end
zachgoll (Migrated from github.com) commented 2024-08-09 04:36:03 +08:00
Copy Link

Mostly style here, but could we keep this consistent with the fetch_security_prices method stub?

  def fetch_exchange_rates(from:, to:, start_date:, end_date:)
Mostly style here, but could we keep this consistent with the `fetch_security_prices` method stub? ```suggestion def fetch_exchange_rates(from:, to:, start_date:, end_date:) ```
tonyvince (Migrated from github.com) reviewed 2024-08-09 15:07:15 +08:00
app/models/exchange_rate/provided.rb
@@ -15,0 +30,4 @@
end
else
[]
end
tonyvince (Migrated from github.com) commented 2024-08-09 15:07:15 +08:00
Copy Link

Yes!

Yes!
tonyvince (Migrated from github.com) reviewed 2024-08-09 15:07:27 +08:00
app/models/provider/synth.rb
@@ -57,12 +57,40 @@ class Provider::Synth
end
tonyvince (Migrated from github.com) commented 2024-08-09 15:07:27 +08:00
Copy Link

Done.

Done.
zachgoll (Migrated from github.com) approved these changes 2024-08-09 22:57:27 +08:00
zachgoll (Migrated from github.com) left a comment
Copy Link

Great work, thanks for the help here!

Great work, thanks for the help here!
Sign in to join this conversation.
Reviewers
No Reviewers
tonyvince
zachgoll
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#1069
Delete Branch "1047-make-bulk-calls-to-synth-api"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?