Rubocop updates #1118

2024-08-23T22:03:36+08:00

zachgoll commented

2024-08-23 22:03:36 +08:00

(Migrated from github.com)

No functional code changes here; just formatting and linting due to changing a few Rubocop rules and running rubocop -a on the codebase.

Added .editorconfig with a minimal set of rules (no tabs, 2 spaces)
Added some Rubocop rules around indentation

In general, we'll stay away from adding too many Rubocop rules, but enforcing 2 spaces is helpful

No functional code changes here; just formatting and linting due to changing a few Rubocop rules and running `rubocop -a` on the codebase. - Added `.editorconfig` with a minimal set of rules (no tabs, 2 spaces) - Added some Rubocop rules around indentation In general, we'll stay away from adding too many Rubocop rules, but enforcing 2 spaces is helpful

zachgoll (Migrated from github.com) reviewed 2024-08-23 22:05:15 +08:00

.rubocop.yml

zachgoll (Migrated from github.com) commented

2024-08-23 22:05:15 +08:00

The Rails omakase config disables this one and prefers %i[ items with space ].

That said, there is no Cop rule that can enforce this. Given the OSS nature of this project, consistency is the most important thing; hence adding this rule in.

The Rails omakase config disables this one and prefers `%i[ items with space ]`. That said, there is no Cop rule that can enforce this. Given the OSS nature of this project, consistency is the most important thing; hence adding this rule in.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#1118