Finish remaining transaction filters #1189

2024-09-17T04:26:53+08:00

zachgoll commented

2024-09-17 04:26:53 +08:00

(Migrated from github.com)

We introduced transaction filtering a while back, but a few of the filters were not ready to be implemented.

This PR completes the remaining "coming soon" transaction filters so users have full control over their transactions dashboard.

We introduced transaction filtering a while back, but a few of the filters were not ready to be implemented. This PR completes the remaining "coming soon" transaction filters so users have full control over their transactions dashboard.

zachgoll (Migrated from github.com) reviewed 2024-09-17 06:16:19 +08:00

app/models/account/entry.rb

						
				@@ -151,0 +167,4 @@

				        when "greater"

				          query = query.where("ABS(account_entries.amount) > ?", params[:amount].to_f.abs)

				        end

				      end

zachgoll (Migrated from github.com) commented

2024-09-17 06:16:18 +08:00

If we have to add more filters in the future, this is definitely a refactor candidate, but given this is the final set of filters for a while, no need right now.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#1189