gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Skip account valuation on entry balance_after_entry #1435

Merged
bruno-costanzo merged 1 commits from 1418-skip-account-valuation-on-balance-after-entry into main 2024-11-08 22:17:55 +08:00
Conversation 1 Commits 1 Files Changed 3 +16 -3
bruno-costanzo commented 2024-11-08 21:00:10 +08:00 (Migrated from github.com)
Copy Link

Why?

Partially Fixes 1418

When creating a transaction after an account valuation, the latter should not be considered in the calculation of the balance of the entry.

What?

Change the entry model in order to skip the account valuation amount in the balance_after_entry
image

What should we test?

Create an account valuation and a transaction after, and ensure the account valuation is not part of the calculation of the balance_after_entry within the context of the transaction.

Pending

There is another error related with Issue 1418, related to the way in which the amount of an account valuation is calculated, which in turn can cause the incorrect icon to be displayed.

Paired with @nicogaldamez

### Why? Partially Fixes [1418](https://github.com/maybe-finance/maybe/issues/1418) When creating a transaction after an account valuation, the latter should not be considered in the calculation of the balance of the entry. ### What? Change the entry model in order to skip the account valuation amount in the balance_after_entry ![image](https://github.com/user-attachments/assets/3b3739ab-63f2-4c09-923b-6fe05562db43) ### What should we test? Create an account valuation and a transaction after, and ensure the account valuation is not part of the calculation of the balance_after_entry within the context of the transaction. ### Pending There is another error related with [Issue 1418](https://github.com/maybe-finance/maybe/issues/1418), related to the way in which the amount of an account valuation is calculated, which in turn can cause the incorrect icon to be displayed. Paired with @nicogaldamez
zachgoll (Migrated from github.com) approved these changes 2024-11-08 22:17:38 +08:00
zachgoll (Migrated from github.com) left a comment
Copy Link

Thanks for the fix here!

Thanks for the fix here!
Sign in to join this conversation.
Reviewers
No Reviewers
zachgoll
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#1435
Delete Branch "1418-skip-account-valuation-on-balance-after-entry"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?