Preserve original transaction names when enriching #1556

2024-12-19T06:39:54+08:00

zachgoll commented

2024-12-19 06:39:54 +08:00

(Migrated from github.com)

A couple of data quality updates in this PR:

Make name required on Account::Entry - since users are able to directly edit this value, enforcing non-nullability makes sense and prevents data quality errors that have come up recently
When enriching transactions, store enriched_name rather than overwriting name. This will allow us to preserve "rollback" abilities in the future if a user wants to revert (or just see) the original txn name before enrichment was applied (increase user confidence in enabling the enrichment feature)
All transactions coming from Plaid accounts will be automatically enriched, regardless of user preference as part of the overall "transformation" of Plaid data to Maybe data. Manual transactions will not be enriched unless explicitly enabled by the user.

A couple of data quality updates in this PR: - Make `name` required on `Account::Entry` - since users are able to directly edit this value, enforcing non-nullability makes sense and prevents data quality errors that have come up recently - When enriching transactions, store `enriched_name` rather than overwriting `name`. This will allow us to preserve "rollback" abilities in the future if a user wants to revert (or just see) the original txn name before enrichment was applied (increase user confidence in enabling the enrichment feature) - All transactions coming from Plaid accounts will be automatically enriched, regardless of user preference as part of the overall "transformation" of Plaid data to Maybe data. Manual transactions will not be enriched unless explicitly enabled by the user.

zachgoll (Migrated from github.com) reviewed 2024-12-19 23:15:47 +08:00

db/migrate/20241218132503_add_enriched_name_field.rb

						
				@@ -0,0 +23,4 @@

				            WHEN 'Account::Valuation' THEN 'Balance update'

				            ELSE 'Unknown entry'

				          END

				          WHERE name IS NULL

zachgoll (Migrated from github.com) commented

2024-12-19 23:15:47 +08:00

only updating "bad data" that currently exists

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#1556