gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Add ability to delete all tags #2200

Merged
ahatzz11 merged 4 commits from mass-delete-tags into main 2025-05-06 00:43:46 +08:00
Conversation 3 Commits 4 Files Changed 11 +37 -17
ahatzz11 commented 2025-05-03 09:03:06 +08:00 (Migrated from github.com)
Copy Link

I've done a few imports that I messed up and have a lot of tags that I don't want/care about, and I'd love to be able to start fresh. I think having the ability to mass select tags (or categories) for deletion would be great as well in the future, but as a starting point I thought I'd bring tags up to the same functionality that categories have.

https://github.com/user-attachments/assets/5a970982-cf13-445c-b463-cc2831a9a22e

I also noticed, when copying this from the categories, that the capitalization of the confirmation button was a bit strange. I updated the CustomConfirm to have titlelize for the title & button, and downcase for the text. I think this is a bit nicer looking personally, but happy to revert if others feel differently.

CleanShot-002820 2025-05-02 at 19 57 47@2x

I've done a few imports that I messed up and have a lot of tags that I don't want/care about, and I'd love to be able to start fresh. I think having the ability to mass select tags (or categories) for deletion would be great as well in the future, but as a starting point I thought I'd bring tags up to the same functionality that categories have. https://github.com/user-attachments/assets/5a970982-cf13-445c-b463-cc2831a9a22e I also noticed, when copying this from the categories, that the capitalization of the confirmation button was a bit strange. I updated the `CustomConfirm` to have `titlelize` for the title & button, and `downcase` for the text. I think this is a bit nicer looking personally, but happy to revert if others feel differently. ![CleanShot-002820 2025-05-02 at 19 57 47@2x](https://github.com/user-attachments/assets/cb5b8df0-47fe-488c-bd83-5a3817aa0403)
ahatzz11 (Migrated from github.com) reviewed 2025-05-03 09:04:07 +08:00
app/controllers/tags_controller.rb
@@ -37,0 +37,4 @@
def destroy_all
Current.family.tags.destroy_all
redirect_back_or_to tags_path, notice: "All tags deleted"
end
ahatzz11 (Migrated from github.com) commented 2025-05-03 09:04:07 +08:00
Copy Link

I'm still new to rails, but some of the functionality you can build out in a handful of lines of code is kinda insane

I'm still new to rails, but some of the functionality you can build out in a handful of lines of code is kinda insane
zachgoll (Migrated from github.com) reviewed 2025-05-06 00:40:59 +08:00
app/controllers/tags_controller.rb
@@ -37,0 +37,4 @@
def destroy_all
Current.family.tags.destroy_all
redirect_back_or_to tags_path, notice: "All tags deleted"
end
zachgoll (Migrated from github.com) commented 2025-05-06 00:40:59 +08:00
Copy Link

The appeal of Rails for sure!

The appeal of Rails for sure!
zachgoll (Migrated from github.com) approved these changes 2025-05-06 00:42:50 +08:00
zachgoll (Migrated from github.com) left a comment
Copy Link

Agree, this is a nice feature for users who have a mess of tags they want to cleanup. And definitely matches up with our existing "delete all" pattern.

Agree, this is a nice feature for users who have a mess of tags they want to cleanup. And definitely matches up with our existing "delete all" pattern.
Sign in to join this conversation.
Reviewers
No Reviewers
ahatzz11
zachgoll
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#2200
Delete Branch "mass-delete-tags"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?