gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Fix Plaid cash balance double counting #2222

Merged
zachgoll merged 5 commits from zachgoll/plaid-cash-security-handling into main 2025-05-09 00:25:54 +08:00
Conversation 0 Commits 5 Files Changed 8 +72 -97
zachgoll commented 2025-05-08 09:43:24 +08:00 (Migrated from github.com)
Copy Link

This PR reconciles the differences in our internal domain model for handling cash balances on investment accounts and Plaid's domain model.

Plaid vs. Maybe cash balance handling

Plaid combines brokerage cash + cash equivalent investments all into a single bucket called "cash", which is reported as available_balance.

Unlike Plaid, Maybe internally draws a hard line between brokerage cash (i.e. "uninvested cash") and "holdings".

This causes a double-count because internally, we add cash + holdings value to arrive at balance. Since Plaid's available_balance has various types of cash combined, when we do our cash + holdings value = balance calculation, we get cash/cash equivalent holdings counted twice.

This PR preemptively backs out these cash equivalents from the reported available_balance to fit our internal domain model better and avoid double-counting account values.

This PR reconciles the differences in our internal domain model for handling cash balances on investment accounts and Plaid's domain model. **Plaid vs. Maybe cash balance handling** Plaid combines brokerage cash + cash equivalent investments all into a single bucket called "cash", which is reported as `available_balance`. Unlike Plaid, Maybe internally draws a hard line between **brokerage cash** (i.e. "uninvested cash") and "holdings". This causes a double-count because internally, we add `cash + holdings value` to arrive at `balance`. Since Plaid's `available_balance` has various types of cash combined, when we do our `cash + holdings value = balance` calculation, we get cash/cash equivalent holdings counted _twice_. This PR preemptively _backs out_ these cash equivalents from the reported `available_balance` to fit our internal domain model better and avoid double-counting account values.
🎉 1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#2222
Delete Branch "zachgoll/plaid-cash-security-handling"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?