Use single list for desktop and mobile nav bars #2227

2025-05-09T03:51:28+08:00

ahatzz11 commented

2025-05-09 03:51:28 +08:00

(Migrated from github.com)

When working on the rules, I noticed that the "Rules" item in the settings nav wasn't available on mobile. Digging into this, desktop and mobile were using two different hardcoded list. I've changed this so both views are dynamically generated from a single list, which simplifies the nav bar code, ensures rules shows up on mobile, and future proofs the nav bars from diverging.

This also moves the "Rules" text to the locales file.

When working on the rules, I noticed that the "Rules" item in the settings nav wasn't available on mobile. Digging into this, desktop and mobile were using two different hardcoded list. I've changed this so both views are dynamically generated from a single list, which simplifies the nav bar code, ensures rules shows up on mobile, and future proofs the nav bars from diverging. This also moves the `"Rules"` text to the locales file.

👍 1

zachgoll (Migrated from github.com) approved these changes 2025-05-09 21:52:14 +08:00

zachgoll (Migrated from github.com) left a comment

Good idea here!

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#2227