gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Standardize corners, backgrounds, and borders #2271

Merged
ahatzz11 merged 16 commits from corners-and-containers into main 2025-05-21 22:28:57 +08:00
Conversation 1 Commits 16 Files Changed 13 +57 -61
ahatzz11 commented 2025-05-21 05:25:57 +08:00 (Migrated from github.com)
Copy Link

This PR does a bunch of design standardization on corners, backgrounds, borders, and more. I chatted with @justinfar about most of this. I think this fixes all of the current weird things with corners/borders, but if there are any more that I didn't spot I can fix them up.

Fix a bunch proper rounding on corners (should step from rounded-xl -> rounded-lg)
image

Fix some double borders (border alongside shadow-border-:
image

Fix table on imports:
image

Fix dark mode for merchants:
CleanShot-003121 2025-05-20 at 15 54 07@2x

This PR does a bunch of design standardization on corners, backgrounds, borders, and more. I chatted with @justinfar about most of this. I _think_ this fixes all of the current weird things with corners/borders, but if there are any more that I didn't spot I can fix them up. --- Fix a bunch proper rounding on corners (should step from `rounded-xl` -> `rounded-lg`) ![image](https://github.com/user-attachments/assets/f7fef7f3-bf64-43ed-83fd-e57fca515d49) Fix some double borders (`border` alongside `shadow-border-`: ![image](https://github.com/user-attachments/assets/d989ab39-b4a9-4d95-b65d-343e275dabf1) Fix table on imports: ![image](https://github.com/user-attachments/assets/8fe8c9e2-b9e2-4219-bb09-e3ead0dcc1ce) Fix dark mode for merchants: ![CleanShot-003121 2025-05-20 at 15 54 07@2x](https://github.com/user-attachments/assets/9ed0d0f5-caa2-4412-a79e-38631d867c7b)
zachgoll (Migrated from github.com) approved these changes 2025-05-21 22:28:43 +08:00
zachgoll (Migrated from github.com) left a comment
Copy Link

Very nice! I had tried to catch as many of these as I could in my design overhaul but there were a lot of them 😅 Definitely looking sharper now!

Very nice! I had tried to catch as many of these as I could in my design overhaul but there were a lot of them 😅 Definitely looking sharper now!
Sign in to join this conversation.
Reviewers
No Reviewers
zachgoll
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#2271
Delete Branch "corners-and-containers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?