Add new ai chat button, tweak ai navigation #2272

Merged
ahatzz11 merged 10 commits from new-ai-chat-button into main 2025-05-22 23:38:05 +08:00
ahatzz11 commented 2025-05-21 10:05:24 +08:00 (Migrated from github.com)

I've been playing with the AI chat a bit, and some of the navigation of it all kept tripping me up so I thought I'd suggest a couple of improvements!

  1. Add a 'new chat' button to the main page. A new chat being hidden behind the 3 dot menu of an existing chat felt a bit strange - this option hasn't been removed. The default chat on the dashboard load is also still the most recent chat.
image
  1. Tweak the navigation in the AI chat. Currently when you're on a new chat there's a 3 line button that puts you back to the 'main chat page', and the main chat page has a back button which takes you to your most recent. This feels very unintuitive to me - when I'm inside of something it makes sense to go 'back' to something else. If I'm on the main menu I don't expect to really go 'back' to a chat that is within that menu. If I'm alone on this, happy to swap this back to the current behavior! You can see the lack of a back button on the main page above, and here is the new back button on each chat:

CleanShot-003141 2025-05-20 at 20 59 14@2x

  1. Fix the padding around the nav title on a new chat

CleanShot-003143 2025-05-20 at 21 03 20@2x

I've been playing with the AI chat a bit, and some of the navigation of it all kept tripping me up so I thought I'd suggest a couple of improvements! 1. Add a 'new chat' button to the main page. A new chat being hidden behind the 3 dot menu of an existing chat felt a bit strange - this option hasn't been removed. The default chat on the dashboard load is also still the most recent chat. <img width="426" alt="image" src="https://github.com/user-attachments/assets/66e63fc8-3570-4d48-80cd-b4fa48f0c8a5" /> 2. Tweak the navigation in the AI chat. Currently when you're on a new chat there's a 3 line button that puts you back to the 'main chat page', and the main chat page has a back button which takes you to your most recent. This feels very unintuitive to me - when I'm inside of something it makes sense to go 'back' to something else. If I'm on the main menu I don't expect to really go 'back' to a chat that is within that menu. If I'm alone on this, happy to swap this back to the current behavior! You can see the lack of a back button on the main page above, and here is the new back button on each chat: ![CleanShot-003141 2025-05-20 at 20 59 14@2x](https://github.com/user-attachments/assets/a1eef24f-d1e4-485e-acaf-2c3c5431cf31) 3. Fix the padding around the nav title on a new chat ![CleanShot-003143 2025-05-20 at 21 03 20@2x](https://github.com/user-attachments/assets/a0b4f4bb-b551-4253-809e-251e125732ea)
Shpigford commented 2025-05-21 22:16:23 +08:00 (Migrated from github.com)

bugbot run

bugbot run
cursor[bot] commented 2025-05-21 22:16:26 +08:00 (Migrated from github.com)

Bug: Tailwind Padding Class Error

The Tailwind class string was changed to "md:p4". This is not a valid Tailwind class name (it should be "md:p-4"), so the intended medium-screen padding will not be applied, leading to layout/spacing issues.

app/views/chats/new.html.erb#L1-L2

45dbe79eba/app/views/chats/new.html.erb (L1-L2)

Fix in Cursor


Was this report helpful? Give feedback by reacting with 👍 or 👎

<details open> <summary><h3>Bug: Tailwind Padding Class Error</h3></summary> The Tailwind class string was changed to "md:p4". This is not a valid Tailwind class name (it should be "md:p-4"), so the intended medium-screen padding will not be applied, leading to layout/spacing issues. <p></p> <details> <summary><code>app/views/chats/new.html.erb#L1-L2</code></summary> https://github.com/maybe-finance/maybe/blob/45dbe79eba71d61e8b6a948914edf5c4fb96fe0b/app/views/chats/new.html.erb#L1-L2 </details> <a href="https://cursor.com/open?data=eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCIsImtpZCI6ImJ1Z2JvdC12MSJ9.eyJ0eXBlIjoiQlVHQk9UX0ZJWF9JTl9DVVJTT1IiLCJkYXRhIjp7ImJ1ZyI6ImV5SnNiMk5oZEdsdmJuTWlPbHQ3SW1acGJHVWlPaUpoY0hBdmRtbGxkM012WTJoaGRITXZibVYzTG1oMGJXd3VaWEppSWl3aWMzUmhjblJNYVc1bElqb3hMQ0psYm1STWFXNWxJam95TENKamIyUmxUR2x1WlhNaU9sdGRmVjBzSW1sa0lqb2laalk0WW1ZeE1tRXRZelJtT0MwMFpqRTNMV0l3T0RNdFlXTmxOamhsWXpSbE1HSTRJaXdpWkdWelkzSnBjSFJwYjI0aU9pSlVhR1VnVkdGcGJIZHBibVFnWTJ4aGMzTWdjM1J5YVc1bklIZGhjeUJqYUdGdVoyVmtJSFJ2SUZ3aWJXUTZjRFJjSWk0Z1ZHaHBjeUJwY3lCdWIzUWdZU0IyWVd4cFpDQlVZV2xzZDJsdVpDQmpiR0Z6Y3lCdVlXMWxJQ2hwZENCemFHOTFiR1FnWW1VZ1hDSnRaRHB3TFRSY0lpa3NJSE52SUhSb1pTQnBiblJsYm1SbFpDQnRaV1JwZFcwdGMyTnlaV1Z1SUhCaFpHUnBibWNnZDJsc2JDQnViM1FnWW1VZ1lYQndiR2xsWkN3Z2JHVmhaR2x1WnlCMGJ5QnNZWGx2ZFhRdmMzQmhZMmx1WnlCcGMzTjFaWE11SWl3aVkyOXVabWxrWlc1alpTSTZNQzQ1T1RReU5UUTNPRFkzTnpJd056Y3hMQ0pqWVhSbFoyOXllU0k2SWt4UFIwbERYMEpWUnlKOSIsImJyYW5jaCI6Im5ldy1haS1jaGF0LWJ1dHRvbiJ9LCJpYXQiOjE3NDc4MzcxOTAsImV4cCI6MTc0ODQ0MTk5MH0.V5oU3J2wkdC-hELWL4gfZYogRTyIbE9gBMYQlthMUY6aaisQ7Y8BQGg1bK1Is1e_eS3F5BvrH2tX4BSopH8QwjEWP6GczKjEpjIEi0ntOOVwF1Vn0yh3J3UYI9w6YTNPE1Uz_qYg9ZGIEiEQX5erQJ20tk1eb_Yfuk4xNs1FUX3CoEELExH-6UIhCzme9SGtbn_CtaUOuJ3XQ_cWDvCdxo8Xlxkj4R61rQJrloCouAFMiauC7HuKcaW_4T7MHYcQrxLwZjLl3H8UeEKgMGQau3J8Mu5ztGOtFmKPN4lPTk97ieE42hcY04vNIhO41Ym5SSDVfktcauSANzIhebXUiQ">Fix in Cursor</a> </details> --- _Was this report helpful? Give feedback by reacting with 👍 or 👎_
zachgoll commented 2025-05-21 22:37:50 +08:00 (Migrated from github.com)

@ahatzz11 I think I agree with this regarding the "back" arrow vs. menu. At least to my brain, hitting a "back arrow" would mean, "Take me back to the menu".

@justinfar is there an interaction flow you've got planned out down the road where we'll need to keep the existing UI flow? Or is this change good to go?

@ahatzz11 I think I agree with this regarding the "back" arrow vs. menu. At least to my brain, hitting a "back arrow" would mean, "Take me back to the menu". @justinfar is there an interaction flow you've got planned out down the road where we'll need to keep the existing UI flow? Or is this change good to go?
ahatzz11 commented 2025-05-21 23:18:31 +08:00 (Migrated from github.com)

bugbot run

bugbot run
justinfar commented 2025-05-21 23:52:07 +08:00 (Migrated from github.com)

In terms of:

  • Fixing the padding for the nav title
  • Adding a "plus" icon button (should be 36x36 container and 20x20 icon) that lets users start a new chat

All good re that

In terms of tweaking the navigation and adding a back button on the recent chat and removing it within the Chats view, I'm also fine with that. The only point I wanted to make here is that I'd retain the menu icon (instead of using the left arrow) as that's meant to signify "All chats", instead of "Go back to Chats".

image

image

Other than that good to go on these changes!

In terms of: - Fixing the padding for the nav title - Adding a "plus" icon button (should be 36x36 container and 20x20 icon) that lets users start a new chat All good re that In terms of tweaking the navigation and adding a back button on the recent chat and removing it within the Chats view, I'm also fine with that. The only point I wanted to make here is that I'd retain the menu icon (instead of using the left arrow) as that's meant to signify "All chats", instead of "Go back to Chats". ![image](https://github.com/user-attachments/assets/6dc422d7-8951-4334-9f03-2778636260d3) ![image](https://github.com/user-attachments/assets/2f33337f-61d4-4935-a864-549174e6edd0) Other than that good to go on these changes!
ahatzz11 commented 2025-05-22 00:34:46 +08:00 (Migrated from github.com)

@justinfar @zachgoll all fixed! Icon is the proper size - the 'back' button is now the menu button to go back to the list. I personally still find this a bit odd, but we can keep that one!

@justinfar @zachgoll all fixed! Icon is the proper size - the 'back' button is now the menu button to go back to the list. I personally still find this a bit odd, but we can keep that one!
zachgoll (Migrated from github.com) approved these changes 2025-05-22 23:37:59 +08:00
Sign in to join this conversation.