gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Fix: ticker combobox background and text color #2370

Merged
KenTandrian merged 2 commits from bugfix/combobox-bg into main 2025-06-16 21:58:37 +08:00
Conversation 2 Commits 2 Files Changed 1 +5 -1
KenTandrian commented 2025-06-15 15:16:16 +08:00 (Migrated from github.com)
Copy Link

This PR fixes the issue where the hotwire combobox input field and dropdown options have white background in dark mode, which extremely reduces visibility.

Changes

  • Fix ticker combobox input and options background color in dark mode by adding bg-container class.
  • Fix the input text color by adding text-primary class.

Before

Screenshot 2025-06-15 at 14 00 12

After

Dark mode

Screenshot 2025-06-15 at 14 00 44

Light mode

Screenshot 2025-06-15 at 14 14 01

This PR fixes the issue where the hotwire combobox input field and dropdown options have white background in dark mode, which extremely reduces visibility. ## Changes * Fix ticker combobox input and options background color in dark mode by adding `bg-container` class. * Fix the input text color by adding `text-primary` class. ## Before ![Screenshot 2025-06-15 at 14 00 12](https://github.com/user-attachments/assets/f6fafcf9-ff97-4258-af90-111ee4feaf74) ## After ### Dark mode ![Screenshot 2025-06-15 at 14 00 44](https://github.com/user-attachments/assets/b2cbbb02-7ef8-4a52-96fe-395a0c6acc7f) ### Light mode ![Screenshot 2025-06-15 at 14 14 01](https://github.com/user-attachments/assets/116d9ca7-d4fd-48a9-8bcc-d93eac3a22bd)
cursor[bot] commented 2025-06-15 15:16:24 +08:00 (Migrated from github.com)
Copy Link

🚨 BugBot couldn't run

Pull requests from forked repositories are not yet supported (requestId: serverGenReqId_16696984-04ef-441e-adb2-cc588f040641).

<h3>🚨 BugBot couldn't run</h3> Pull requests from forked repositories are not yet supported (requestId: serverGenReqId_16696984-04ef-441e-adb2-cc588f040641).
zachgoll (Migrated from github.com) approved these changes 2025-06-16 21:58:31 +08:00
zachgoll (Migrated from github.com) left a comment
Copy Link

Awesome, looks great. Thanks for the fix!

Awesome, looks great. Thanks for the fix!
Sign in to join this conversation.
Reviewers
No Reviewers
zachgoll
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#2370
Delete Branch "bugfix/combobox-bg"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?