gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Centralize auth messages #269

Merged
josefarias merged 7 commits from jose/centralize-auth-msgs into main 2024-02-04 04:17:49 +08:00
Conversation 1 Commits 7 Files Changed 17 +138 -55
josefarias commented 2024-02-03 14:06:53 +08:00 (Migrated from github.com)
Copy Link

Closes https://github.com/maybe-finance/maybe/issues/264

At first, I thought by "centralize" we meant we wanted all the copy for the messages in a single place for easy editing. So I added rudimentary i18n, as well as i18n-tasks, which helps keep i18n files tidy. (That's on me for not paying attention, sorry I jumped the gun here)

Then I realized we actually wanted the messages to all appear in a single place for auth-related forms, so I pulled out a helper for that, too.

Let me know if we don't want the i18n part of this. Happy to take it out.

To be clear, there's still plenty of i18n work left to do — this was more meant to organize the auth messages. The rest of the app needs to be configured still. We can tackle that work as part of https://github.com/maybe-finance/maybe/issues/256.

Closes https://github.com/maybe-finance/maybe/issues/264 At first, I thought by "centralize" we meant we wanted all the copy for the messages in a single place for easy editing. So I added rudimentary i18n, as well as [i18n-tasks](https://github.com/glebm/i18n-tasks), which helps keep i18n files tidy. (That's on me for not paying attention, sorry I jumped the gun here) Then I realized we actually wanted the messages to all appear in a single place for auth-related forms, so I pulled out a helper for that, too. Let me know if we don't want the i18n part of this. Happy to take it out. To be clear, there's still plenty of i18n work left to do — this was more meant to organize the auth messages. The rest of the app needs to be configured still. We can tackle that work as part of https://github.com/maybe-finance/maybe/issues/256.
👍 1
Shpigford commented 2024-02-04 00:18:33 +08:00 (Migrated from github.com)
Copy Link

@josefarias Couple of conflicts that popped up from a PR merge this morning.

@josefarias Couple of conflicts that popped up from a PR merge this morning.
👍 1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#269
Delete Branch "jose/centralize-auth-msgs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?