gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Split authentication concern from ApplicationController #289

Merged
dwightwatson merged 3 commits from authentication_concern into main 2024-02-05 03:05:13 +08:00
Conversation 2 Commits 3 Files Changed 2 +44 -34
dwightwatson commented 2024-02-04 17:47:32 +08:00 (Migrated from github.com)
Copy Link

This breaks out all the authentication methods from the root ApplicationController into a specific concern and includes it.

It might be interesting to replace the need for current_user and current_family helpers altogether - I'd imagine using the Current model directly should suffice. Happy to explore that if you're down for it.

This breaks out all the authentication methods from the root `ApplicationController` into a specific concern and includes it. It might be interesting to replace the need for `current_user` and `current_family` helpers altogether - I'd imagine using the `Current` model directly should suffice. Happy to explore that if you're down for it.
robzolkos (Migrated from github.com) approved these changes 2024-02-04 22:45:20 +08:00
Shpigford commented 2024-02-05 03:05:10 +08:00 (Migrated from github.com)
Copy Link

@dwightwatson Good work on this!

Re: replacing current_user/current_family, you're welcome to open a draft PR exploring that. Just be sure to layout pros/cons.

@dwightwatson Good work on this! Re: replacing `current_user`/`current_family`, you're welcome to open a draft PR exploring that. Just be sure to layout pros/cons.
Sign in to join this conversation.
Reviewers
No Reviewers
robzolkos
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#289
Delete Branch "authentication_concern"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?