Fix height of modal during account creation steps #418

2024-02-10T09:19:05+08:00

robzolkos commented

2024-02-10 09:19:05 +08:00

(Migrated from github.com)

A modal that has a number of steps should avoid giving the user whiplash with changing heights. Keeping the height consistent during the flow makes the move from modal screen to modal screen smoother (and also elements like back buttons remain in consistent positions).

Before

After

This change also adds a tweak to the modal javascript to early return from opening the modal if its already open.

A modal that has a number of steps should avoid giving the user whiplash with changing heights. Keeping the height consistent during the flow makes the move from modal screen to modal screen smoother (and also elements like back buttons remain in consistent positions). ### Before ![CleanShot 2024-02-09 at 20 14 45](https://github.com/maybe-finance/maybe/assets/290616/922400c3-7a46-4deb-9a7a-1bd1df0a41ac) ### After ![CleanShot 2024-02-09 at 20 16 06](https://github.com/maybe-finance/maybe/assets/290616/d2ea6078-d4d5-48c7-a12d-723df87460ea) This change also adds a tweak to the modal javascript to early return from opening the modal if its already open.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#418