gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Scaffold out the UI for individual account page #461

Merged
zachgoll merged 6 commits from account-page into main 2024-02-15 02:02:11 +08:00
Conversation 0 Commits 6 Files Changed 47 +724 -12
zachgoll commented 2024-02-15 00:21:13 +08:00 (Migrated from github.com)
Copy Link

CleanShot 2024-02-14 at 11 19 39

PR Notes

This PR is a rough sketch of the account page. Code is not optimized and will need to eventually be refactored and all data is placeholder.

  • Data model for AccountBalance (eventually will be loaded into the UI placeholders)
  • Account page UI layout (all interactivity disabled for now)
  • D3.js line chart with basic tooltip

Notes on D3 usage

  • For now, have imported the entire D3 library via bin/importmap pin d3
  • Pinned a local file, app/javascript/tailwindColors.js which mirrors our tailwind.config.js and allows us to use referenced styles directly in our controllers for style consistency.
    • Eventually, we should probably write a Rake task that reads tailwind.config.js and automatically generates this file so the two stay in sync
    • Used an @maybe namespace that can be used for future local JS files
![CleanShot 2024-02-14 at 11 19 39](https://github.com/maybe-finance/maybe/assets/16676157/3cdd5b52-569d-42dd-a4e6-163bb467a6ab) ## PR Notes This PR is a rough sketch of the account page. Code is not optimized and will need to eventually be refactored and all data is placeholder. - Data model for `AccountBalance` (eventually will be loaded into the UI placeholders) - Account page UI layout (all interactivity disabled for now) - D3.js line chart with basic tooltip ## Notes on D3 usage - For now, have imported the entire D3 library via `bin/importmap pin d3` - Pinned a local file, `app/javascript/tailwindColors.js` which mirrors our `tailwind.config.js` and allows us to use referenced styles directly in our controllers for style consistency. - Eventually, we should probably write a Rake task that reads `tailwind.config.js` and automatically generates this file so the two stay in sync - Used an `@maybe` namespace that can be used for future local JS files
🎉 2
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#461
Delete Branch "account-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?