Use our .ruby-version file in Bundler so it is managed in only 1 place #520

2024-03-06T14:45:48+08:00

corsonknowles commented

2024-03-06 14:45:48 +08:00

(Migrated from github.com)

This provides a single source of truth and simplifies staying current on Ruby.

Background writeup: https://gorails.com/episodes/bundler-ruby-version-file
Original issue: https://github.com/rubygems/rubygems/issues/6742
Implementation: https://github.com/rubygems/rubygems/pull/6876

This provides a single source of truth and simplifies staying current on Ruby. Background writeup: https://gorails.com/episodes/bundler-ruby-version-file Original issue: https://github.com/rubygems/rubygems/issues/6742 Implementation: https://github.com/rubygems/rubygems/pull/6876

🎉 1

robzolkos commented

2024-03-07 13:58:14 +08:00

(Migrated from github.com)

This change will break the Dockerfile as the .ruby-version file isn't copied over when bundler is run. (I think we reverted this change due to this a while back). Rails main has removed the ruby version from the Gemfile completely last I checked (a couple of weeks ago). Anyway you may get some issues raised with Docker no longer working for some peeps.

❤️ 1

corsonknowles commented

2024-03-07 16:54:34 +08:00

(Migrated from github.com)

Thanks @robzolkos This is a widely used and much beloved new feature of Bundler. I was about to say I'll take a look at what is idiosyncratic about our Dockerfile tomorrow, but from the helpful description you provided, I think we can simply do this:

https://github.com/maybe-finance/maybe/pull/523

Thanks @robzolkos This is a widely used and much beloved new feature of Bundler. I was about to say I'll take a look at what is idiosyncratic about our Dockerfile tomorrow, but from the helpful description you provided, I think we can simply do this: * https://github.com/maybe-finance/maybe/pull/523

❤️ 1

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#520