gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Fix event handler removal on disconnect #540

Merged
jakubkottnauer merged 2 commits from fix-removeeventhandler-disconnect into main 2024-03-12 05:42:18 +08:00
Conversation 3 Commits 2 Files Changed 5 +19 -25
jakubkottnauer commented 2024-03-12 04:11:20 +08:00 (Migrated from github.com)
Copy Link

Calling .bind(this) always returns a new function, meaning that event handlers registered in connect callbacks were never properly removed in disconnect callbacks. Creating event handlers as arrow functions fixed this and also makes the code simpler.

Calling `.bind(this)` always returns a new function, meaning that event handlers registered in `connect` callbacks were never properly removed in `disconnect` callbacks. Creating event handlers as arrow functions fixed this and also makes the code simpler.
zachgoll (Migrated from github.com) reviewed 2024-03-12 04:27:36 +08:00
zachgoll (Migrated from github.com) left a comment
Copy Link

The code does look nicer, but this introduces some bugs, likely related to Turbo as shown in the video below. In order for tab content to show, a full browser refresh is required:

https://github.com/maybe-finance/maybe/assets/16676157/55c9aa27-74db-4ba9-ba7d-2a36201dcc19

The code does look nicer, but this introduces some bugs, likely related to Turbo as shown in the video below. In order for tab content to show, a full browser refresh is required: https://github.com/maybe-finance/maybe/assets/16676157/55c9aa27-74db-4ba9-ba7d-2a36201dcc19
jakubkottnauer commented 2024-03-12 05:12:51 +08:00 (Migrated from github.com)
Copy Link

@zachgoll Well spotted! I have pushed a fix, the issue was that the updateClasses method in tab-controller was receiving the turbo event as the first argument (but it expected the tab to select).

@zachgoll Well spotted! I have pushed a fix, the issue was that the `updateClasses` method in `tab-controller` was receiving the turbo event as the first argument (but it expected the tab to select).
🎉 1
zachgoll commented 2024-03-12 05:42:07 +08:00 (Migrated from github.com)
Copy Link

@jakubkottnauer awesome, looks good now!

@jakubkottnauer awesome, looks good now!
Sign in to join this conversation.
Reviewers
No Reviewers
zachgoll
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#540
Delete Branch "fix-removeeventhandler-disconnect"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?