feat: add crypto account type to demo data #555

2024-03-20T00:01:42+08:00

jbrodriguez commented

2024-03-20 00:01:42 +08:00

(Migrated from github.com)

This adds a Crypto asset account type to the demo data, to more accurately resemble the main screenshot on the repo

zachgoll (Migrated from github.com) reviewed 2024-03-20 01:30:50 +08:00

db/schema.rb

zachgoll (Migrated from github.com) commented

2024-03-20 01:29:46 +08:00

Was this change a result of the migration? Or a manual change?

lib/tasks/demo_data.rake

						
				@@ -222,0 +231,4 @@

				    { date: 200.days.ago.to_date, value: 0.06, currency: "BTC" },

				    { date: 100.days.ago.to_date, value: 0.08, currency: "BTC" },

				    { date: 20.days.ago.to_date, value: 0.1, currency: "BTC" }

				    ]

zachgoll (Migrated from github.com) commented

2024-03-20 01:28:56 +08:00

For a sample account like Bitcoin, we'll want to make sure and specify the currency, BTC and adjust these values to be smaller so that when it is converted to the family's currency (likely USD), it will represent a reasonable proportion of the portfolio. I'd say somewhere around 0.1 is probably appropriate for a demo account (~$6,500 worth of BTC)

For a sample account like Bitcoin, we'll want to make sure and specify the currency, `BTC` and adjust these values to be smaller so that when it is converted to the family's currency (likely USD), it will represent a reasonable proportion of the portfolio. I'd say somewhere around `0.1` is probably appropriate for a demo account (~$6,500 worth of BTC)

jbrodriguez (Migrated from github.com) reviewed 2024-03-20 01:33:05 +08:00

db/schema.rb

jbrodriguez (Migrated from github.com) commented

2024-03-20 01:33:05 +08:00

it was a result of the migration, i'll revert it

zachgoll (Migrated from github.com) reviewed 2024-03-20 01:36:16 +08:00

test/fixtures/account/cryptos.yml

						
				@@ -0,0 +8,4 @@

				# column: value

				#

				# two: {}

				# column: value

zachgoll (Migrated from github.com) commented

2024-03-20 01:36:16 +08:00

These are the cause of the CI test failure. Since an Accountable must always be associated with an Account, these create orphaned records that break the account rollups.

You can comment all of this out to fix.

These are the cause of the CI test failure. Since an `Accountable` must always be associated with an `Account`, these create orphaned records that break the account rollups. You can comment all of this out to fix.

jbrodriguez commented

2024-03-20 02:00:26 +08:00

(Migrated from github.com)

@zachgoll i reverted the schema change, commented out the data for the test to run and changed the currency to BTC

however, the dashboard shows the account in USD, thought it had to do with multi-currency, so registered with synth, but there's no BTC "currency" there

i'll dig a bit more ... the idea is to show each account in its base currency or convert everything to USD ?

@zachgoll i reverted the schema change, commented out the data for the test to run and changed the currency to BTC however, the dashboard shows the account in USD, thought it had to do with multi-currency, so registered with synth, but there's no BTC "currency" there ![Screenshot 2024-03-19 at 12 53 13](https://github.com/maybe-finance/maybe/assets/1305422/e4920efc-0a37-45f8-a327-b9ef23165c3a) i'll dig a bit more ... the idea is to show each account in its base currency or convert everything to USD ?

👍 1

zachgoll commented

2024-03-20 02:08:14 +08:00

(Migrated from github.com)

@jbrodriguez yep, that's expected right now. I've got a bunch of local changes for #543 that will be pushed soon to fix that and make all of this work correctly though!

When that goes in, each account will display its own currency (in this case, number of bitcoins) and then in the sidebar and dashboard, the values will be exchanged (via Synth) and "rolled up" into the Family's preferred currency.

@jbrodriguez yep, that's expected right now. I've got a bunch of local changes for #543 that will be pushed soon to fix that and make all of this work correctly though! When that goes in, each account will display its own currency (in this case, number of bitcoins) and then in the sidebar and dashboard, the values will be exchanged (via Synth) and "rolled up" into the `Family`'s preferred currency.

👍 1

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#555