gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Implement savings rate insight card #670

Merged
JoshAntBrown merged 1 commits from feature/savings-insight-card into main 2024-04-24 22:02:22 +08:00
Conversation 3 Commits 1 Files Changed 7 +89 -54
JoshAntBrown commented 2024-04-24 05:36:57 +08:00 (Migrated from github.com)
Copy Link

This PR builds upon #668 and adds the savings rate insight card to the dashboard.

I'll keep this in draft until #668 is resolved.

Screenshot 2024-04-23 at 22 35 19

Resolves #646
/claim #646

This PR builds upon #668 and adds the savings rate insight card to the dashboard. I'll keep this in draft until #668 is resolved. <img width="1510" alt="Screenshot 2024-04-23 at 22 35 19" src="https://github.com/maybe-finance/maybe/assets/1793797/280f8c53-5ec8-46b7-92a5-c1a049df2459"> Resolves #646 /claim #646
zachgoll (Migrated from github.com) reviewed 2024-04-24 20:40:23 +08:00
zachgoll (Migrated from github.com) left a comment
Copy Link

@JoshAntBrown overall code here makes sense, so after those merge conflicts are resolved I'll do a final review and merge.

@JoshAntBrown overall code here makes sense, so after those merge conflicts are resolved I'll do a final review and merge.
JoshAntBrown commented 2024-04-24 21:45:26 +08:00 (Migrated from github.com)
Copy Link

Thanks! Should all be ready now 👍

Thanks! Should all be ready now 👍
zachgoll (Migrated from github.com) approved these changes 2024-04-24 22:02:14 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
zachgoll
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label 🙋 Bounty claim
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#670
Delete Branch "feature/savings-insight-card"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?