gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Add bulk selection UI controls #840

Merged
zachgoll merged 5 commits from 798-build-bulk-selection-ui-for-transactions into main 2024-06-08 00:44:06 +08:00
Conversation 2 Commits 5 Files Changed 11 +256 -8
zachgoll commented 2024-06-07 01:33:42 +08:00 (Migrated from github.com)
Copy Link

This PR introduces a Stimulus controller to handle bulk selection of transactions (although the controller is generic to any collection of records).

https://github.com/maybe-finance/maybe/assets/16676157/b0e7d89f-a534-4245-b60c-4ca44cadb65b

Future PRs will handle the bulk edit and delete operations.

This PR introduces a Stimulus controller to handle bulk selection of transactions (although the controller is generic to any collection of records). https://github.com/maybe-finance/maybe/assets/16676157/b0e7d89f-a534-4245-b60c-4ca44cadb65b Future PRs will handle the bulk edit and delete operations.
zachgoll (Migrated from github.com) reviewed 2024-06-07 01:35:33 +08:00
app/views/accounts/transactions/_transaction.html.erb
@@ -0,0 +14,4 @@
<div class="col-span-2 ml-auto">
<%= render "transactions/amount", transaction: transaction %>
</div>
<% end %>
zachgoll (Migrated from github.com) commented 2024-06-07 01:35:32 +08:00
Copy Link

As the global transactions UI is getting a lot more complex with bulk selection and inline editing, I decided to make the transaction rows in the account view read-only for the time being.

Eventually we'll probably want to mirror some of the functionality implemented in the global view here, but trying to manage this in two spots adds unnecessary complexity right now.

As the global transactions UI is getting a lot more complex with bulk selection and inline editing, I decided to make the transaction rows in the account view read-only for the time being. Eventually we'll probably want to mirror some of the functionality implemented in the global view here, but trying to manage this in two spots adds unnecessary complexity right now.
zachgoll (Migrated from github.com) reviewed 2024-06-07 01:36:20 +08:00
config/routes.rb
@@ -45,4 +45,2 @@
collection do
match "search" => "transactions#search", via: %i[ get post ]
scope module: :transactions, as: :transaction do
zachgoll (Migrated from github.com) commented 2024-06-07 01:36:20 +08:00
Copy Link

stale route that I missed earlier in the transactions cleanup

stale route that I missed earlier in the transactions cleanup
Sign in to join this conversation.
Reviewers
No Reviewers
zachgoll
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#840
Delete Branch "798-build-bulk-selection-ui-for-transactions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?