Account namespace updates: part 1 (accountable types) #893

2024-06-20T05:42:59+08:00

zachgoll commented

2024-06-20 05:42:59 +08:00

(Migrated from github.com)

See #892 for a detailed proposal of these changes. I will be opening several PRs to achieve the final state so there is a semi-readable history of the changes.

Part 1 is intended to:

Add system tests for creating various types of accounts
Move accountable "subtypes" to the global namespace

Before this PR:

app/models
├── account
│   ├── balance
│   │   └── calculator.rb
│   ├── balance.rb
│   ├── credit.rb
│   ├── crypto.rb
│   ├── depository.rb
│   ├── investment.rb
│   ├── loan.rb
│   ├── other_asset.rb
│   ├── other_liability.rb
│   ├── property.rb
│   ├── syncable.rb
│   └── vehicle.rb
├── account.rb

After this PR:

app/models
├── account
│   ├── balance
│   │   └── calculator.rb
│   ├── balance.rb
│   └── syncable.rb
├── account.rb
├── credit_card.rb
├── crypto.rb
├── depository.rb
├── investment.rb
├── loan.rb
├── other_asset.rb
├── other_liability.rb
├── property.rb
└── vehicle.rb

See #892 for a detailed proposal of these changes. I will be opening several PRs to achieve the final state so there is a semi-readable history of the changes. Part 1 is intended to: 1. Add system tests for creating various types of accounts 2. Move accountable "subtypes" to the global namespace Before this PR: ``` app/models ├── account │ ├── balance │ │ └── calculator.rb │ ├── balance.rb │ ├── credit.rb │ ├── crypto.rb │ ├── depository.rb │ ├── investment.rb │ ├── loan.rb │ ├── other_asset.rb │ ├── other_liability.rb │ ├── property.rb │ ├── syncable.rb │ └── vehicle.rb ├── account.rb ``` After this PR: ``` app/models ├── account │ ├── balance │ │ └── calculator.rb │ ├── balance.rb │ └── syncable.rb ├── account.rb ├── credit_card.rb ├── crypto.rb ├── depository.rb ├── investment.rb ├── loan.rb ├── other_asset.rb ├── other_liability.rb ├── property.rb └── vehicle.rb ```

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#893