Sanitize input for ilike in Account::Entry.search #988

2024-07-16T20:36:34+08:00

tonyvince commented

2024-07-16 20:36:34 +08:00

(Migrated from github.com)

Fixes #987

tonyvince commented

2024-07-16 21:05:44 +08:00

(Migrated from github.com)

A trigram index on account_entries.name might be beneficial

A [trigram index](https://thoughtbot.com/blog/choosing-the-right-database-index-type#pattern-matching-with-likeilike-gin-index) on `account_entries.name` might be beneficial

zachgoll (Migrated from github.com) approved these changes 2024-07-16 21:24:53 +08:00

zachgoll commented

2024-07-16 21:26:09 +08:00

(Migrated from github.com)

A trigram index on account_entries.name might be beneficial

Yeah I think this along with a few other indexes could be helpful to the search process. I've kept it pretty minimal and unoptimized for now though since we'll eventually be introducing a "global" search and my guess is that we'll have to rethink some of it anyways.

> A [trigram index](https://thoughtbot.com/blog/choosing-the-right-database-index-type#pattern-matching-with-likeilike-gin-index) on `account_entries.name` might be beneficial Yeah I think this along with a few other indexes could be helpful to the search process. I've kept it pretty minimal and unoptimized for now though since we'll eventually be introducing a "global" search and my guess is that we'll have to rethink some of it anyways.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#988