gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Fix: No comma when locality is empty (small fix) #2111

Merged
LEstradioto merged 4 commits from no-locality-comma-fix into main 2025-04-17 09:26:45 +08:00
Conversation 3 Commits 4 Files Changed 3 +41 -7
LEstradioto commented 2025-04-15 02:17:54 +08:00 (Migrated from github.com)
Copy Link

Currently when Properties have empty address it shows a single comma on subtitle
image

This PR pushes a fix for that, when no Locality is saved, there is no comma

And, perhaps, another fix could be added here.

It seems i18n format should supposed be shown like right side of image? If so, I could just update that too.

image

Currently when Properties have empty address it shows a single comma on subtitle ![image](https://github.com/user-attachments/assets/8ddc224e-8c98-4230-ad82-f8323d0b1076) This PR pushes a fix for that, when no Locality is saved, there is no comma And, perhaps, another fix could be added here. It seems i18n format should supposed be shown like right side of image? If so, I could just update that too. ![image](https://github.com/user-attachments/assets/a916ef21-f961-4643-acb9-55cf87bba9f7)
Shpigford commented 2025-04-16 23:40:32 +08:00 (Migrated from github.com)
Copy Link

@LEstradioto So "proper" for a one-liner would actually be a comma after the street name as well.

123 Main St, San Francisco, CA 94105 US

@LEstradioto So "proper" for a one-liner would actually be a comma after the street name as well. `123 Main St, San Francisco, CA 94105 US`
LEstradioto commented 2025-04-17 01:27:39 +08:00 (Migrated from github.com)
Copy Link

Great, thanks. Address string will now follow the I18n formatting and as a one-liner

Great, thanks. Address string will now follow the I18n formatting and as a one-liner
Shpigford commented 2025-04-17 09:26:56 +08:00 (Migrated from github.com)
Copy Link

Merged. Thanks so much, @LEstradioto!

Merged. Thanks so much, @LEstradioto!
👍 1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#2111
Delete Branch "no-locality-comma-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?