Fixes #2100: this will fix the problem of text not visible in the modal when dark theme is set #2112

Merged

DSY4444 merged 3 commits from fix/issue-2100-dark-theme-does-not-allow-text-to-be-visible-in-modal into main 2025-04-22 21:06:52 +08:00

Conversation 6 Commits 3 Files Changed 2 +3 -3

DSY4444 commented 2025-04-15 22:01:10 +08:00 (Migrated from github.com)

Copy Link

Added 'text-primary' inside the class, this will pick the appropriate system color based on theme

Added 'text-primary' inside the class, this will pick the appropriate system color based on theme

👀 1

Shpigford commented 2025-04-16 23:38:29 +08:00 (Migrated from github.com)

Copy Link

Thanks so much, @DSY4444! Can you add a screenshot of the result of your changes? Helps us review/approve PRs much faster.

Thanks so much, @DSY4444! Can you add a screenshot of the result of your changes? Helps us review/approve PRs much faster.

DSY4444 commented 2025-04-21 13:47:01 +08:00 (Migrated from github.com)

Copy Link

sure, @Shpigford I'll add screenshots showing difference

sure, @Shpigford I'll add screenshots showing difference

DSY4444 commented 2025-04-21 13:47:58 +08:00 (Migrated from github.com)

Copy Link

before

before <img width="566" alt="Screenshot 2025-04-21 at 11 14 02 AM" src="https://github.com/user-attachments/assets/c321e6b8-3626-4edb-9d52-c0c2527798d9" /> <img width="483" alt="Screenshot 2025-04-21 at 11 14 56 AM" src="https://github.com/user-attachments/assets/de2e324d-b3cd-432b-bcfb-6f7c021b1e65" />

DSY4444 commented 2025-04-21 13:48:33 +08:00 (Migrated from github.com)

Copy Link

after

after <img width="554" alt="Screenshot 2025-04-21 at 11 15 25 AM" src="https://github.com/user-attachments/assets/dcc4e217-cdda-4b39-b8df-47d2f3058b3c" /> <img width="483" alt="Screenshot 2025-04-21 at 11 15 50 AM" src="https://github.com/user-attachments/assets/ef9a1b4a-5de9-45bc-bedf-352f05a37baa" />

DSY4444 commented 2025-04-21 13:49:45 +08:00 (Migrated from github.com)

Copy Link

As you can see the visibility of text changes based on theme, earlier it was not the case.

As you can see the visibility of text changes based on theme, earlier it was not the case.

SolarWolf-Code commented 2025-04-27 14:14:57 +08:00 (Migrated from github.com)

Copy Link

@DSY4444 i think some of the elements are still applying the incorrect color

  @DSY4444 i think some of the elements are still applying the incorrect color

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

📆 Planned

Not ready to be worked on yet, but planned for future

💻 Self Hosted only

Issues pertaining to self-hosted versions of Maybe

⚙️ Config

ℹ️ Needs info

Further information is requested

📱 Mobile

Bugs exclusively happening on mobile devices

1️⃣ High Priority

High priority issues will be worked on next

🚨 Urgent

Issues that are urgent for app functionality

3️⃣ Low priority

Contributions accepted, but Maybe team will not be working on this in the near term

2️⃣ Medium Priority

Community contributions accepted, Maybe team only works on if there are no high priority items open

⚡ Performance

Performance issues to address

🎨 UI / UX

Issues related to UI / UX interactions and design.

💎 Bounty

💰 Rewarded

📊 Data issue

Issues where the app functionally works, but the data is missing or inaccurate.

🙋 Bounty claim

$1.5K

Community

This is a great issue for community members to work on

dependencies

Pull requests that update a dependency file

Design

Hosted only

Hosted app only

Required self hoster data migration

Self hosters must run data migrations to resolve this issue

ruby

Pull requests that update Ruby code

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

gavin

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#2112