Feat: Mobile Settings menu with preserve scroll + scroll on connect #2278

2025-05-22T08:32:58+08:00

LEstradioto commented

2025-05-22 08:32:58 +08:00

(Migrated from github.com)

Here is a quick video:

https://github.com/user-attachments/assets/a7075c75-0721-4c6b-aaba-15df8838cc3c

scroll_on_connect_controller are meant to be generic, could be reused to scroll any scrollable content passing a css selector argument
preserve_scroll_controller handles horizontal and vertical, meant to be re-usable too

Here is a quick video: https://github.com/user-attachments/assets/a7075c75-0721-4c6b-aaba-15df8838cc3c * `scroll_on_connect_controller` are meant to be generic, could be reused to scroll any scrollable content passing a css selector argument * `preserve_scroll_controller` handles horizontal and vertical, meant to be re-usable too

zachgoll commented

2025-05-22 23:38:29 +08:00

(Migrated from github.com)

bugbot run

zachgoll (Migrated from github.com) approved these changes 2025-05-22 23:46:36 +08:00

zachgoll (Migrated from github.com) left a comment

Nice touches!

app/javascript/controllers/scroll_on_connect_controller.js

						
				@@ -0,0 +1,41 @@

				import { Controller } from "@hotwired/stimulus"

zachgoll (Migrated from github.com) commented

2025-05-22 23:45:41 +08:00

```suggestion ```

zachgoll (Migrated from github.com) commented

2025-05-22 23:45:52 +08:00

```suggestion ```

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#2278

				`@@ -0,0 +1,41 @@`
				`import { Controller } from "@hotwired/stimulus"`