gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

feat: remove Intercom usage #27

Merged
MichaelDeBoey merged 1 commits from remove-intercom-usage into main 2024-01-11 22:51:51 +08:00
Conversation 2 Commits 1 Files Changed 19 +18 -255
MichaelDeBoey commented 2024-01-11 17:12:21 +08:00 (Migrated from github.com)
Copy Link

Closes #22

I already started working on this before I saw @tamirfyi's #26 🙈

Still noticed some differences:

  • No formatting changes
  • Also removed unused imports
  • No removal of the useAccounts hook from libs/client/shared/src/api/useAccountApi.ts (its usage wasn't removed from the rest of the codebase either in #26)
  • No yarn.lock changes (should be done in a separate PR imo)
  • No Prisma migration (should be done in a separate PR imo)
Closes #22 --- I already started working on this before I saw @tamirfyi's #26 🙈 Still noticed some differences: - No formatting changes - Also removed unused imports - No removal of the `useAccounts` hook from `libs/client/shared/src/api/useAccountApi.ts` (its usage wasn't removed from the rest of the codebase either in #26) - No `yarn.lock` changes (should be done in a separate PR imo) - No Prisma migration (should be done in a separate PR imo)
Shpigford commented 2024-01-11 22:51:44 +08:00 (Migrated from github.com)
Copy Link

@MichaelDeBoey Let's go with yours (primarily due to the useAccounts bit).

@MichaelDeBoey Let's go with yours (primarily due to the `useAccounts` bit).
👍 1
tamirmb commented 2024-01-12 01:25:41 +08:00 (Migrated from github.com)
Copy Link

I tried getting this one right before bed since it seemed easier than others, but I guess I was tired and overlooked some things. nice work michael!

I tried getting this one right before bed since it seemed easier than others, but I guess I was tired and overlooked some things. nice work michael!
❤️ 3
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#27
Delete Branch "remove-intercom-usage"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?