gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Fix: Omit layout for turbo frames with custom sidebar layout #1024

Merged
pranavbabu merged 2 commits from fix/ommit-layout-for-turbo-frames-with-custom-sidebar-layout into main 2024-07-27 00:00:41 +08:00
Conversation 1 Commits 2 Files Changed 14 +69 -49
pranavbabu commented 2024-07-26 23:05:21 +08:00 (Migrated from github.com)
Copy Link

This PR folows this hint for turbo frame usage https://github.com/hotwired/turbo-rails?tab=readme-ov-file#a-note-on-custom-layouts and implements custom method for with sidebar layout. This change will ommit rendering layout when turbo frame request is used. It improves performance by returning much smaller html as example for rendering New account modal with layout server retruns 165 KB (request time: 235ms) of html with this change server returns 1.6 KB (request time: 35ms).

This PR folows this hint for turbo frame usage [https://github.com/hotwired/turbo-rails?tab=readme-ov-file#a-note-on-custom-layouts](url) and implements custom method for with sidebar layout. This change will ommit rendering layout when turbo frame request is used. It improves performance by returning much smaller html as example for rendering New account modal with layout server retruns 165 KB (request time: 235ms) of html with this change server returns 1.6 KB (request time: 35ms).
zachgoll (Migrated from github.com) approved these changes 2024-07-26 23:59:57 +08:00
zachgoll (Migrated from github.com) left a comment
Copy Link

Nice idea here, especially with the expensive calculations that are needed for our sidebar layout.

Nice idea here, especially with the expensive calculations that are needed for our sidebar layout.
Sign in to join this conversation.
Reviewers
No Reviewers
zachgoll
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#1024
Delete Branch "fix/ommit-layout-for-turbo-frames-with-custom-sidebar-layout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?