gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Bump good_job from 4.1.0 to 4.1.1 #1053

Merged
dependabot[bot] merged 1 commits from dependabot/bundler/good_job-4.1.1 into main 2024-08-05 21:00:32 +08:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
dependabot[bot] commented 2024-08-05 15:09:14 +08:00 (Migrated from github.com)
Copy Link

Bumps good_job from 4.1.0 to 4.1.1.

Release notes

Sourced from good_job's releases.

v4.1.1

Review the Changelog for more details.

What's Changed

New Contributors

Full Changelog: https://github.com/bensheldon/good_job/compare/v4.1.0...v4.1.1

Changelog

Sourced from good_job's changelog.

v4.1.1 (2024-07-31)

Full Changelog

Implemented enhancements:

  • Convert Concurrency extension to use transaction-level (xact) advisory locks #1439 (bensheldon)

Fixed bugs:

  • Fix N+1 on dashboard batches index page #1442 (bensheldon)
  • Remove duplicate word on batches show page #1441 (Earlopain)
  • Ensure remaining inline jobs are unlocked when one job raises in Adapter#enqueue_all #1438 (bensheldon)

Closed issues:

  • Using Good Job to track all ActiveJob executions, even those with perform_now #1448
  • RuntimeError when running good_job executable after updating v3 -> v4 #1445
  • 2.99 -> 3.0.2 migration not applying cleanly from a fresh DB #1435
  • [Enhance] Enhance performance via counter cache #1375
  • Change how svg images are inserted into partials #1364

Merged pull requests:

  • Improve some Spanish transcriptions #1452 (sebastian-cloudnonic)
  • All running jobs now have performed_at set so use that in status query; fix flaky test that took advisory lock in before block #1444 (bensheldon)
  • Handle empty asset format in Frontends controller #1443 (bensheldon)
  • Update development dependencies, Ruby 3.3.4 #1437 (bensheldon)
  • Refactor inline adapter to enable deferred execution after enqueue to allow batch-callbacks to use transaction-based advisory lock #1433 (bensheldon)
  • German translation pass #1432 (Earlopain)
  • Add Brakeman to linters #1431 (bensheldon)
  • Remove references to and ignore good_jobs.retried_good_job_id column #1430 (bensheldon)
  • Refactor Concurrency extension for Rails 6.1+ compatibility #1429 (bensheldon)
  • Use svg use for svg icons #1428 (Earlopain)
  • Replace references to "Discrete" executions with simply Executions; deprecate GoodJob::DiscreteExecution #1427 (bensheldon)
  • Refactor Adapter to reference jobs, not executions #1426 (bensheldon)

v1.99.2 (2024-07-18)

Full Changelog

Commits
  • 0e758d7 Release good_job v4.1.1
  • a3bf936 Improve some Spanish transcriptions (#1452)
  • 02fb0b6 Refactor inline adapter to enable deferred execution after enqueue to allow b...
  • eaace45 Convert Concurrency extension to use transaction-level (xact) advisory locks ...
  • fa3660d All running jobs now have performed_at set so use that in status query; fix...
  • fbd216f Fix N+1 on dashboard batches index page (#1442)
  • f464ff9 Handle empty asset format in Frontends controller (#1443)
  • 17d3369 Use svg use for svg icons (#1428)
  • b7018c1 Remove duplicate word on batches show page (#1441)
  • 0a2ffa8 German translation pass (#1432)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Bumps [good_job](https://github.com/bensheldon/good_job) from 4.1.0 to 4.1.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bensheldon/good_job/releases">good_job's releases</a>.</em></p> <blockquote> <h2>v4.1.1</h2> <p><em>Review the <a href="https://github.com/bensheldon/good_job/blob/main/CHANGELOG.md#v411-2024-07-31">Changelog</a> for more details.</em></p> <h2>What's Changed</h2> <ul> <li>Refactor Adapter to reference jobs, not executions by <a href="https://github.com/bensheldon"><code>@​bensheldon</code></a> in <a href="https://redirect.github.com/bensheldon/good_job/pull/1426">bensheldon/good_job#1426</a></li> <li>Replace references to &quot;Discrete&quot; executions with simply Executions; deprecate <code>GoodJob::DiscreteExecution</code> by <a href="https://github.com/bensheldon"><code>@​bensheldon</code></a> in <a href="https://redirect.github.com/bensheldon/good_job/pull/1427">bensheldon/good_job#1427</a></li> <li>Refactor Concurrency extension for Rails 6.1+ compatibility by <a href="https://github.com/bensheldon"><code>@​bensheldon</code></a> in <a href="https://redirect.github.com/bensheldon/good_job/pull/1429">bensheldon/good_job#1429</a></li> <li>Remove references to and ignore <code>good_jobs.retried_good_job_id</code> column by <a href="https://github.com/bensheldon"><code>@​bensheldon</code></a> in <a href="https://redirect.github.com/bensheldon/good_job/pull/1430">bensheldon/good_job#1430</a></li> <li>Add Brakeman to linters by <a href="https://github.com/bensheldon"><code>@​bensheldon</code></a> in <a href="https://redirect.github.com/bensheldon/good_job/pull/1431">bensheldon/good_job#1431</a></li> <li>Ensure remaining inline jobs are unlocked when one job raises in Adapter#enqueue_all by <a href="https://github.com/bensheldon"><code>@​bensheldon</code></a> in <a href="https://redirect.github.com/bensheldon/good_job/pull/1438">bensheldon/good_job#1438</a></li> <li>Update development dependencies, Ruby 3.3.4 by <a href="https://github.com/bensheldon"><code>@​bensheldon</code></a> in <a href="https://redirect.github.com/bensheldon/good_job/pull/1437">bensheldon/good_job#1437</a></li> <li>German translation pass by <a href="https://github.com/Earlopain"><code>@​Earlopain</code></a> in <a href="https://redirect.github.com/bensheldon/good_job/pull/1432">bensheldon/good_job#1432</a></li> <li>Remove duplicate word on batches show page by <a href="https://github.com/Earlopain"><code>@​Earlopain</code></a> in <a href="https://redirect.github.com/bensheldon/good_job/pull/1441">bensheldon/good_job#1441</a></li> <li>Use svg <code>use</code> for svg icons by <a href="https://github.com/Earlopain"><code>@​Earlopain</code></a> in <a href="https://redirect.github.com/bensheldon/good_job/pull/1428">bensheldon/good_job#1428</a></li> <li>Handle empty asset format in Frontends controller by <a href="https://github.com/bensheldon"><code>@​bensheldon</code></a> in <a href="https://redirect.github.com/bensheldon/good_job/pull/1443">bensheldon/good_job#1443</a></li> <li>Fix N+1 on dashboard batches index page by <a href="https://github.com/bensheldon"><code>@​bensheldon</code></a> in <a href="https://redirect.github.com/bensheldon/good_job/pull/1442">bensheldon/good_job#1442</a></li> <li>All running jobs now have <code>performed_at</code> set so use that in status query; fix flaky test that took advisory lock in <code>before</code> block by <a href="https://github.com/bensheldon"><code>@​bensheldon</code></a> in <a href="https://redirect.github.com/bensheldon/good_job/pull/1444">bensheldon/good_job#1444</a></li> <li>Convert Concurrency extension to use transaction-level (xact) advisory locks by <a href="https://github.com/bensheldon"><code>@​bensheldon</code></a> in <a href="https://redirect.github.com/bensheldon/good_job/pull/1439">bensheldon/good_job#1439</a></li> <li>Refactor inline adapter to enable deferred execution after enqueue to allow batch-callbacks to use transaction-based advisory lock by <a href="https://github.com/bensheldon"><code>@​bensheldon</code></a> in <a href="https://redirect.github.com/bensheldon/good_job/pull/1433">bensheldon/good_job#1433</a></li> <li>Improve some Spanish transcriptions by <a href="https://github.com/sebastian-cloudnonic"><code>@​sebastian-cloudnonic</code></a> in <a href="https://redirect.github.com/bensheldon/good_job/pull/1452">bensheldon/good_job#1452</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/sebastian-cloudnonic"><code>@​sebastian-cloudnonic</code></a> made their first contribution in <a href="https://redirect.github.com/bensheldon/good_job/pull/1452">bensheldon/good_job#1452</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/bensheldon/good_job/compare/v4.1.0...v4.1.1">https://github.com/bensheldon/good_job/compare/v4.1.0...v4.1.1</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/bensheldon/good_job/blob/main/CHANGELOG.md">good_job's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/bensheldon/good_job/tree/v4.1.1">v4.1.1</a> (2024-07-31)</h2> <p><a href="https://github.com/bensheldon/good_job/compare/v1.99.2...v4.1.1">Full Changelog</a></p> <p><strong>Implemented enhancements:</strong></p> <ul> <li>Convert Concurrency extension to use transaction-level (xact) advisory locks <a href="https://redirect.github.com/bensheldon/good_job/pull/1439">#1439</a> (<a href="https://github.com/bensheldon">bensheldon</a>)</li> </ul> <p><strong>Fixed bugs:</strong></p> <ul> <li>Fix N+1 on dashboard batches index page <a href="https://redirect.github.com/bensheldon/good_job/pull/1442">#1442</a> (<a href="https://github.com/bensheldon">bensheldon</a>)</li> <li>Remove duplicate word on batches show page <a href="https://redirect.github.com/bensheldon/good_job/pull/1441">#1441</a> (<a href="https://github.com/Earlopain">Earlopain</a>)</li> <li>Ensure remaining inline jobs are unlocked when one job raises in Adapter#enqueue_all <a href="https://redirect.github.com/bensheldon/good_job/pull/1438">#1438</a> (<a href="https://github.com/bensheldon">bensheldon</a>)</li> </ul> <p><strong>Closed issues:</strong></p> <ul> <li>Using Good Job to track all ActiveJob executions, even those with <code>perform_now</code> <a href="https://redirect.github.com/bensheldon/good_job/issues/1448">#1448</a></li> <li>RuntimeError when running good_job executable after updating v3 -&gt; v4 <a href="https://redirect.github.com/bensheldon/good_job/issues/1445">#1445</a></li> <li>2.99 -&gt; 3.0.2 migration not applying cleanly from a fresh DB <a href="https://redirect.github.com/bensheldon/good_job/issues/1435">#1435</a></li> <li>[Enhance] Enhance performance via counter cache <a href="https://redirect.github.com/bensheldon/good_job/issues/1375">#1375</a></li> <li>Change how svg images are inserted into partials <a href="https://redirect.github.com/bensheldon/good_job/issues/1364">#1364</a></li> </ul> <p><strong>Merged pull requests:</strong></p> <ul> <li>Improve some Spanish transcriptions <a href="https://redirect.github.com/bensheldon/good_job/pull/1452">#1452</a> (<a href="https://github.com/sebastian-cloudnonic">sebastian-cloudnonic</a>)</li> <li>All running jobs now have <code>performed_at</code> set so use that in status query; fix flaky test that took advisory lock in <code>before</code> block <a href="https://redirect.github.com/bensheldon/good_job/pull/1444">#1444</a> (<a href="https://github.com/bensheldon">bensheldon</a>)</li> <li>Handle empty asset format in Frontends controller <a href="https://redirect.github.com/bensheldon/good_job/pull/1443">#1443</a> (<a href="https://github.com/bensheldon">bensheldon</a>)</li> <li>Update development dependencies, Ruby 3.3.4 <a href="https://redirect.github.com/bensheldon/good_job/pull/1437">#1437</a> (<a href="https://github.com/bensheldon">bensheldon</a>)</li> <li>Refactor inline adapter to enable deferred execution after enqueue to allow batch-callbacks to use transaction-based advisory lock <a href="https://redirect.github.com/bensheldon/good_job/pull/1433">#1433</a> (<a href="https://github.com/bensheldon">bensheldon</a>)</li> <li>German translation pass <a href="https://redirect.github.com/bensheldon/good_job/pull/1432">#1432</a> (<a href="https://github.com/Earlopain">Earlopain</a>)</li> <li>Add Brakeman to linters <a href="https://redirect.github.com/bensheldon/good_job/pull/1431">#1431</a> (<a href="https://github.com/bensheldon">bensheldon</a>)</li> <li>Remove references to and ignore <code>good_jobs.retried_good_job_id</code> column <a href="https://redirect.github.com/bensheldon/good_job/pull/1430">#1430</a> (<a href="https://github.com/bensheldon">bensheldon</a>)</li> <li>Refactor Concurrency extension for Rails 6.1+ compatibility <a href="https://redirect.github.com/bensheldon/good_job/pull/1429">#1429</a> (<a href="https://github.com/bensheldon">bensheldon</a>)</li> <li>Use svg <code>use</code> for svg icons <a href="https://redirect.github.com/bensheldon/good_job/pull/1428">#1428</a> (<a href="https://github.com/Earlopain">Earlopain</a>)</li> <li>Replace references to &quot;Discrete&quot; executions with simply Executions; deprecate <code>GoodJob::DiscreteExecution</code> <a href="https://redirect.github.com/bensheldon/good_job/pull/1427">#1427</a> (<a href="https://github.com/bensheldon">bensheldon</a>)</li> <li>Refactor Adapter to reference jobs, not executions <a href="https://redirect.github.com/bensheldon/good_job/pull/1426">#1426</a> (<a href="https://github.com/bensheldon">bensheldon</a>)</li> </ul> <h2><a href="https://github.com/bensheldon/good_job/tree/v1.99.2">v1.99.2</a> (2024-07-18)</h2> <p><a href="https://github.com/bensheldon/good_job/compare/v4.1.0...v1.99.2">Full Changelog</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/bensheldon/good_job/commit/0e758d7b4b737e5e1e6b755f195c13ac7515a0ec"><code>0e758d7</code></a> Release good_job v4.1.1</li> <li><a href="https://github.com/bensheldon/good_job/commit/a3bf93646fb9e468d2140103c5803aa0f65c4a7d"><code>a3bf936</code></a> Improve some Spanish transcriptions (<a href="https://redirect.github.com/bensheldon/good_job/issues/1452">#1452</a>)</li> <li><a href="https://github.com/bensheldon/good_job/commit/02fb0b67045d0e73d1e5191fc12890734aea1c52"><code>02fb0b6</code></a> Refactor inline adapter to enable deferred execution after enqueue to allow b...</li> <li><a href="https://github.com/bensheldon/good_job/commit/eaace453dfd5e7d509fe4e2b1d55d7ce83434b17"><code>eaace45</code></a> Convert Concurrency extension to use transaction-level (xact) advisory locks ...</li> <li><a href="https://github.com/bensheldon/good_job/commit/fa3660d2e4b9ad72d076db023d5c711fc92f2b97"><code>fa3660d</code></a> All running jobs now have <code>performed_at</code> set so use that in status query; fix...</li> <li><a href="https://github.com/bensheldon/good_job/commit/fbd216f880fee7a2fd7f49d33d2ad2c5c5744ccd"><code>fbd216f</code></a> Fix N+1 on dashboard batches index page (<a href="https://redirect.github.com/bensheldon/good_job/issues/1442">#1442</a>)</li> <li><a href="https://github.com/bensheldon/good_job/commit/f464ff9ee18cfddf011e5fd4f79fe3a1d82e18e2"><code>f464ff9</code></a> Handle empty asset format in Frontends controller (<a href="https://redirect.github.com/bensheldon/good_job/issues/1443">#1443</a>)</li> <li><a href="https://github.com/bensheldon/good_job/commit/17d3369a2b52ff643a58b38f67e233778f74fe9a"><code>17d3369</code></a> Use svg <code>use</code> for svg icons (<a href="https://redirect.github.com/bensheldon/good_job/issues/1428">#1428</a>)</li> <li><a href="https://github.com/bensheldon/good_job/commit/b7018c10052300023cbb959d27ba6ae36f804cdc"><code>b7018c1</code></a> Remove duplicate word on batches show page (<a href="https://redirect.github.com/bensheldon/good_job/issues/1441">#1441</a>)</li> <li><a href="https://github.com/bensheldon/good_job/commit/0a2ffa8bc0c17b45a7652f98e75f1525595f0d81"><code>0a2ffa8</code></a> German translation pass (<a href="https://redirect.github.com/bensheldon/good_job/issues/1432">#1432</a>)</li> <li>Additional commits viewable in <a href="https://github.com/bensheldon/good_job/compare/v4.1.0...v4.1.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=good_job&package-manager=bundler&previous-version=4.1.0&new-version=4.1.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#1053
Delete Branch "dependabot/bundler/good_job-4.1.1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?