gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Fix account transaction form resetting amount to 0 #1133

Merged
zachgoll merged 1 commits from zachgoll/fix-1132 into main 2024-08-27 07:10:17 +08:00
Conversation 2 Commits 1 Files Changed 1 +14 -11
zachgoll commented 2024-08-27 03:51:25 +08:00 (Migrated from github.com)
Copy Link

Fixes #1132

Fixes #1132
zachgoll (Migrated from github.com) reviewed 2024-08-27 03:53:00 +08:00
app/controllers/account/transactions_controller.rb
@@ -15,3 +15,2 @@
@entry.update!(entry_params.merge(amount: amount))
@entry.sync_account_later
@entry.update!(entry_params)
zachgoll (Migrated from github.com) commented 2024-08-27 03:53:00 +08:00
Copy Link

Removed the sync_later because this triggers a refresh of the entire page (via the Sync broadcasts) which gets annoying for updating transaction details. This will cause out-of-sync data if the user changes the amount or date, but will be updated on the next sync.

Eventually we'll want to get more granular with when we trigger the re-sync, but for now this feels like a decent tradeoff.

Removed the `sync_later` because this triggers a refresh of the entire page (via the Sync broadcasts) which gets annoying for updating transaction details. This will cause out-of-sync data if the user changes the amount or date, but will be updated on the next sync. Eventually we'll want to get more granular with _when_ we trigger the re-sync, but for now this feels like a decent tradeoff.
zachgoll (Migrated from github.com) reviewed 2024-08-27 03:53:39 +08:00
app/controllers/account/transactions_controller.rb
@@ -14,3 +14,2 @@
def update
@entry.update!(entry_params.merge(amount: amount))
@entry.sync_account_later
@entry.update!(entry_params)
zachgoll (Migrated from github.com) commented 2024-08-27 03:53:38 +08:00
Copy Link

Merging in amount caused the scenario when we didn't include the param, it was calling nil.to_d, which resulted in 0

Merging in `amount` caused the scenario when we didn't include the param, it was calling `nil.to_d`, which resulted in 0
Sign in to join this conversation.
Reviewers
No Reviewers
zachgoll
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#1133
Delete Branch "zachgoll/fix-1132"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?