gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Allow users to set preferred locale in settings and provide basic date and time localization support #1226

Merged
zachgoll merged 5 commits from 909-allow-users-to-configure-their-locale-and-provide-a-default-date-format-based-on-locale into main 2024-10-03 02:02:17 +08:00
Conversation 0 Commits 5 Files Changed 130 +25190 -10
zachgoll commented 2024-10-02 06:25:09 +08:00 (Migrated from github.com)
Copy Link

As outlined in #1225 , we will be supporting currency, date, and time localization in the near-term for a variety of locales.

The approach I have taken in this PR is incremental adoption of various locales.

I have set the config.i18n.fallbacks = true so that all missing keys fall back to the default locale, which is en. This will allow for an incremental adoption of I18n and will allow users to start setting up their preferred locale and get some immediate improvements rather than waiting for an "all or nothing" change.

All locale translations come directly from the official rails-i18n repo as suggested in the docs.

As outlined in #1225 , we will be supporting currency, date, and time localization in the near-term for a variety of locales. The approach I have taken in this PR is **incremental adoption** of various locales. I have set the `config.i18n.fallbacks = true` so that all missing keys fall back to the default locale, which is `en`. This will allow for an incremental adoption of I18n and will allow users to start setting up their preferred locale and get some immediate improvements rather than waiting for an "all or nothing" change. All locale translations come directly from the official `rails-i18n` repo [as suggested in the docs.](https://guides.rubyonrails.org/i18n.html#resources)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#1226
Delete Branch "909-allow-users-to-configure-their-locale-and-provide-a-default-date-format-based-on-locale"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?