gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

fix: amend inputs on loan, c.c., vehicle, and property partials #1281

Merged
gariasf merged 7 commits from gariasf/rates-number-input into main 2024-10-10 22:45:18 +08:00
Conversation 5 Commits 7 Files Changed 4 +9 -9
gariasf commented 2024-10-10 16:11:03 +08:00 (Migrated from github.com)
Copy Link

It's currently possible to input text on some number values for loans, credit cards, vehicles, and property. When happens and the form is submitted, it is gracefully handled by setting the value to zero.
This PR proposes that those inputs are number inputs, with appropriate min and step values. % values have a step of 0.1 and both % and currency inputs have a min of 0. This assumes that negative interest rates are VERY rare in personal finance. With that said, I am not sure if it makes sense to put in a negative balance, so I'll be expecting to hear your thoughts on that.
Ideally, these inputs should display the currency symbol or percentage symbol, but that isn't such a trivial change, so I left it out for now.

Looking forward to your feedback. Cheers!

It's currently possible to input text on some number values for loans, credit cards, vehicles, and property. When happens and the form is submitted, it is gracefully handled by setting the value to zero. This PR proposes that those inputs are number inputs, with appropriate min and step values. % values have a step of 0.1 and both % and currency inputs have a min of 0. This assumes that negative interest rates are VERY rare in personal finance. With that said, I am not sure if it makes sense to put in a negative balance, so I'll be expecting to hear your thoughts on that. Ideally, these inputs should display the currency symbol or percentage symbol, but that isn't such a trivial change, so I left it out for now. Looking forward to your feedback. Cheers!
zachgoll commented 2024-10-10 22:04:51 +08:00 (Migrated from github.com)
Copy Link

@gariasf good catch, 100% agree

@gariasf good catch, 100% agree
zachgoll (Migrated from github.com) reviewed 2024-10-10 22:12:23 +08:00
app/views/accounts/accountables/_credit_card.html.erb
@@ -4,17 +4,17 @@
<div class="space-y-2">
zachgoll (Migrated from github.com) commented 2024-10-10 22:12:23 +08:00
Copy Link
        <%= credit_card_form.number_field :apr, label: t(".apr"), placeholder: t(".apr_placeholder"), min: 0, step: 0.01 %>
```suggestion <%= credit_card_form.number_field :apr, label: t(".apr"), placeholder: t(".apr_placeholder"), min: 0, step: 0.01 %> ```
zachgoll (Migrated from github.com) reviewed 2024-10-10 22:12:36 +08:00
app/views/accounts/accountables/_loan.html.erb
@@ -4,7 +4,7 @@
<div class="space-y-2">
zachgoll (Migrated from github.com) commented 2024-10-10 22:12:36 +08:00
Copy Link
        <%= loan_form.number_field :interest_rate, label: t(".interest_rate"), placeholder: t(".interest_rate_placeholder"), min: 0, step: 0.01 %>
```suggestion <%= loan_form.number_field :interest_rate, label: t(".interest_rate"), placeholder: t(".interest_rate_placeholder"), min: 0, step: 0.01 %> ```
zachgoll commented 2024-10-10 22:13:54 +08:00 (Migrated from github.com)
Copy Link

@gariasf those two suggestions I made should fix the system test failures

@gariasf those two suggestions I made should fix the system test failures
zachgoll (Migrated from github.com) approved these changes 2024-10-10 22:45:13 +08:00
zachgoll (Migrated from github.com) left a comment
Copy Link

Awesome, looks great!

Awesome, looks great!
Sign in to join this conversation.
Reviewers
No Reviewers
zachgoll
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#1281
Delete Branch "gariasf/rates-number-input"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?