Basic account onboarding #1328

2024-10-19T05:13:19+08:00

zachgoll commented

2024-10-19 05:13:19 +08:00

(Migrated from github.com)

Allows a user to select the "mode" their account's are in:

https://github.com/user-attachments/assets/c81495ff-5eb0-4f74-82c4-1d9246c6d7f9

Also includes a few bug fixes around syncing.

Allows a user to select the "mode" their account's are in: https://github.com/user-attachments/assets/c81495ff-5eb0-4f74-82c4-1d9246c6d7f9 Also includes a few bug fixes around syncing.

zachgoll (Migrated from github.com) reviewed 2024-10-19 05:16:11 +08:00

app/views/accounts/accountables/investment/_tabs.html.erb

zachgoll (Migrated from github.com) commented

2024-10-19 05:16:11 +08:00

Will need to come back around and clean a lot of this markup up. Lots of duplication across the accountable views

zachgoll (Migrated from github.com) reviewed 2024-10-19 05:16:47 +08:00

test/models/account/balance/syncer_test.rb

zachgoll (Migrated from github.com) commented

2024-10-19 05:16:47 +08:00

Validates bug when there is a transaction at an earlier date than the first valuation

Muzosh commented

2024-10-31 00:18:36 +08:00

(Migrated from github.com)

@zachgoll

I'm confused. What if I want to use both the way it was before? I.e. adding transactions for personal transaction logging, but also update value based on current's date account appreciation? This is the main reason I chose to use Maybe from other financial managers.

Was this intentionally removed?

The account onboarding offers "Balance only" or "Transactions", suggesting that Transactions would also include Balance input.

Edit: I can see that I can still "update" the value by going into account edit:

But I would argue that this is somewhat cumbersome. I also can't edit the added balance value's date.

@zachgoll I'm confused. What if I want to use both the way it was before? I.e. adding transactions for personal transaction logging, but also update value based on current's date account appreciation? This is the main reason I chose to use Maybe from other financial managers. Was this intentionally removed? The account onboarding offers "Balance only" or "Transactions", suggesting that Transactions would also include Balance input. Edit: I can see that I can still "update" the value by going into account edit: <img width="447" alt="image" src="https://github.com/user-attachments/assets/17a2286f-4540-45df-b74e-84b851e1b55b"> But I would argue that this is somewhat cumbersome. I also can't edit the added balance value's date.

Muzosh commented

2024-10-31 00:35:25 +08:00

(Migrated from github.com)

I would also argue that this splitting accounts into two modes is even more confusing. Let's say I created the account above, with "today's balance" 1 CZK. I then change my mind and convert this account from balance mode to transactions mode and add some transactions on the same day.

The value is not updated because the "today's balance" is still overwriting it.

I guess this is intented (although I could again argue that I added transaction after I updated today's balance on the same day) but now user has even lower chance of figuring out what is going on since he thinks his account is in "transactions only" mode.

If the transactions and current balance modes still play role in the balance calculation (where current balance gets obviously priority based on date), why hide those two behind "choosing account mode" GUI?

I would also argue that this splitting accounts into two modes is even more confusing. Let's say I created the account above, with "today's balance" 1 CZK. I then change my mind and convert this account from balance mode to transactions mode and add some transactions on the same day. The value is not updated because the "today's balance" is still overwriting it. I guess this is intented (although I could again argue that I added transaction **after** I updated today's balance on the same day) but now user has even lower chance of figuring out what is going on since he thinks his account is in "transactions only" mode. If the transactions **and** current balance modes still play role in the balance calculation (where current balance gets obviously priority based on date), why hide those two behind "choosing account mode" GUI?

👍 1

Muzosh commented

2024-10-31 00:42:44 +08:00

(Migrated from github.com)

Also if the account is in "balance only" mode, I can still successfully import transactions. However, after import it gets immediately overwritten by new balance entry which was automatically created with the same value as previous entry for some reason. I don't think this behavior enhance user's ability to know what's going on with their balance.

👍 1

jakubkottnauer commented

2024-10-31 02:03:00 +08:00

(Migrated from github.com)

I was just thinking about the same thing today. I believe a solution here might be introducing a third value tracking mode called "Advanced" which would be a combination of Balance and Transaction tracking mode (= basically the old behavior).

What do you think @zachgoll?

I was just thinking about the same thing today. I believe a solution here might be introducing a third value tracking mode called "Advanced" which would be a combination of Balance and Transaction tracking mode (= basically the old behavior). What do you think @zachgoll?

zachgoll commented

2024-10-31 02:07:09 +08:00

(Migrated from github.com)

I was just thinking about the same thing today. I believe a solution here might be introducing a third value tracking mode called "Advanced" which would be a combination of Balance and Transaction tracking mode (= basically the old behavior).

What do you think @zachgoll?

This is in the works already! It will just be a general "Activity View"

> I was just thinking about the same thing today. I believe a solution here might be introducing a third value tracking mode called "Advanced" which would be a combination of Balance and Transaction tracking mode (= basically the old behavior). > > > > What do you think @zachgoll? This is in the works already! It will just be a general "Activity View"

zachgoll commented

2024-10-31 02:10:27 +08:00

(Migrated from github.com)

Working on an update that will look like this, which we sourced quite a bit of feedback on in Discord:

Working on an update that will look like this, which we sourced quite a bit of feedback on in Discord: ![image](https://github.com/user-attachments/assets/f7bceced-dbb2-4c06-8d04-35661133fd28)

❤️ 2

Muzosh commented

2024-11-22 02:36:48 +08:00

(Migrated from github.com)

@zachgoll I just updated my instance and I'm super satisfied with this activity window. It solves all the issues I have written above :) Good job!

🎉 1

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#1328