Do not include income transactions in liability accounts for savings rate #1385

2024-10-28T22:51:59+08:00

tonyvince commented

2024-10-28 22:51:59 +08:00

(Migrated from github.com)

Fix #1383

tonyvince commented

2024-10-28 22:53:11 +08:00

(Migrated from github.com)

@zachgoll what do you think about this approach?

zachgoll (Migrated from github.com) reviewed 2024-10-28 23:13:49 +08:00

app/models/account/entry.rb

zachgoll (Migrated from github.com) commented

2024-10-28 23:13:49 +08:00

I think we're on the right track here, but I wouldn't make a scope for this given how specific it is to the snapshot_transactions method.

Also, "Income" would be anything less than 0, so I think we need to flip that condition here

I think we're on the right track here, but I wouldn't make a scope for this given how specific it is to the `snapshot_transactions` method. Also, "Income" would be anything _less than_ 0, so I _think_ we need to flip that condition here

zachgoll (Migrated from github.com) approved these changes 2024-10-31 21:04:40 +08:00

zachgoll (Migrated from github.com) left a comment

Nice, I think this should fix it. We'll likely have other little edge cases pop up but I think this is a good step forward.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#1385