Fix registration fails silently when there are errors #1455

2024-11-11T18:20:58+08:00

tonyvince commented

2024-11-11 18:20:58 +08:00

(Migrated from github.com)

Fix #1443 <img width="715" alt="Screenshot 2024-11-11 at 11 17 11" src="https://github.com/user-attachments/assets/c773619d-b589-428e-8a79-24ccf7a70eac">

bennypowers (Migrated from github.com) reviewed 2024-11-11 19:11:31 +08:00

bennypowers (Migrated from github.com) left a comment

suggested for the password_field on line 35

5e0097fd35/app/views/registrations/new.html.erb (L35)

  <%= form.password_field :password, autocomplete: "new-password", required: "required", label: true, :maxlength => 75 %>

based on 1dd82aba34/actionview/lib/action_view/helpers/tags/text_field.rb (L13)

my ruby isn't up to standards so please double check the syntax

suggested for the password_field on line 35 https://github.com/maybe-finance/maybe/blob/5e0097fd3522c8f032895754657c2fdbf6445cef/app/views/registrations/new.html.erb#L35 ```ruby <%= form.password_field :password, autocomplete: "new-password", required: "required", label: true, :maxlength => 75 %> ``` based on https://github.com/rails/rails/blob/1dd82aba340e8a86799bd97fe5ff2644c6972f9f/actionview/lib/action_view/helpers/tags/text_field.rb#L13 my ruby isn't up to standards so please double check the syntax

zachgoll (Migrated from github.com) approved these changes 2024-11-11 22:41:13 +08:00

zachgoll (Migrated from github.com) left a comment

Awesome, thanks!

villancikos commented

2025-02-01 02:38:39 +08:00

(Migrated from github.com)

Hi guys. Sorry to comment in a solved issue but using Safari in a self-hosted environment (docker in Mac M chip), the Safari saved password does not get stored. Therefore, can't login.
I tried resetting password but the email functionality, doesn't work. Tried getting the password from the database at the Users table but obviously I only get the password_digest field.

What options do I have to restore the password or change it locally? If everything is lost, I am still logged in one device... can I export and just create another account?

Hi guys. Sorry to comment in a solved issue but using Safari in a self-hosted environment (docker in Mac M chip), the Safari saved password does not get stored. Therefore, can't login. I tried resetting password but the email functionality, doesn't work. Tried getting the password from the database at the Users table but obviously I only get the password_digest field. What options do I have to restore the password or change it locally? If everything is lost, I am still logged in one device... can I export and just create another account?

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#1455