gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Allow custom column separator for CSV parsing in uploads controller #1470

Merged
acflint merged 2 commits from fix-csv-import into main 2024-11-19 00:31:18 +08:00
Conversation 5 Commits 2 Files Changed 2 +7 -4
acflint commented 2024-11-17 22:54:36 +08:00 (Migrated from github.com)
Copy Link

Fix for this issue: https://github.com/maybe-finance/maybe/issues/1462

csv_valid? wasn't using the submitted col_sep argument, so semicolon separated CSVs were failing to be validated.

Fix for this issue: https://github.com/maybe-finance/maybe/issues/1462 `csv_valid?` wasn't using the submitted `col_sep` argument, so semicolon separated CSVs were failing to be validated.
zachgoll commented 2024-11-18 23:53:16 +08:00 (Migrated from github.com)
Copy Link

@acflint disregard my comment on the other PR that was closed. This looks good!

@acflint disregard my comment on the other PR that was closed. This looks good!
👍 1
acflint commented 2024-11-18 23:56:53 +08:00 (Migrated from github.com)
Copy Link

@zachgoll I can fix the failing specs, if you'd like. Let me know.

@zachgoll I can fix the failing specs, if you'd like. Let me know.
zachgoll commented 2024-11-19 00:01:16 +08:00 (Migrated from github.com)
Copy Link

@acflint yep, that would be great. Looks like we just need to pass col_sep as params for each of those failing tests

@acflint yep, that would be great. Looks like we just need to pass `col_sep` as params for each of those failing tests
acflint commented 2024-11-19 00:04:03 +08:00 (Migrated from github.com)
Copy Link

@zachgoll done 👍🏻

@zachgoll done 👍🏻
🎉 1
acflint commented 2024-11-19 00:41:08 +08:00 (Migrated from github.com)
Copy Link

I know it's small, but after almost 10 years of being a dev, this is the first OSS contribution I've had merged. So that's pretty cool :) Thanks @zachgoll!

I know it's small, but after almost 10 years of being a dev, this is the first OSS contribution I've had merged. So that's pretty cool :) Thanks @zachgoll!
❤️ 1 🎉 1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#1470
Delete Branch "fix-csv-import"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?