Make encryption config optional for self hosting users #1476

2024-11-18T23:19:19+08:00

zachgoll commented

2024-11-18 23:19:19 +08:00

(Migrated from github.com)

In the context of the Maybe app, the encryption module is used in a very narrow scope—for properly storing access tokens for Plaid Items.

Given that self hosters will generally not be managing their own Plaid setup, they will not need the encryption module for a functioning app. The configuration for this module adds quite a bit of overhead to the initial setup for self hosters, so this PR makes it entirely optional. We can adjust this in the future if encryption becomes mandatory for self hosters, but I do not foresee that becoming an issue for quite some time.

In the context of the Maybe app, the encryption module is used in a very narrow scope—for properly storing access tokens for Plaid Items. Given that self hosters will generally not be managing their own Plaid setup, they will not need the encryption module for a functioning app. The configuration for this module adds quite a bit of overhead to the initial setup for self hosters, so this PR makes it entirely optional. We can adjust this in the future if encryption becomes mandatory for self hosters, but I do not foresee that becoming an issue for quite some time.

zachgoll (Migrated from github.com) reviewed 2024-11-18 23:20:03 +08:00

app/controllers/concerns/store_location.rb

						
				@@ -15,0 +21,4 @@

				    else

				      head :not_found

				    end

				  end

zachgoll (Migrated from github.com) commented

2024-11-18 23:20:03 +08:00

Unrelated, fixes a bug where clicking "back" from settings throws a 404 when the "return to" path is the URL of a resource that has been deleted from /accounts page.

Unrelated, fixes a bug where clicking "back" from settings throws a 404 when the "return to" path is the URL of a resource that has been deleted from `/accounts` page.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#1476