Improve account transaction, trade, and valuation editing and sync experience #1506

2024-11-27T11:15:01+08:00

zachgoll commented

2024-11-27 11:15:01 +08:00

(Migrated from github.com)

This PR aims to drastically improve the account entry editing experience.

The current state of the app works as-is, but is very cumbersome in some areas. Current issues include:

Drawer editors closing while editing
Synced data not updating immediately in the UI
Minimal feedback to the user when account data is syncing in the background
Static entry info not updating as the user edits the form below it

Furthermore, there was a ton of code duplication across the entry controllers (valuation, transaction, trade) that has been consolidated to the EntryableResource concern, which follows a similar pattern to the AccountableResource concern introduced in #1406. This provides default implementations for all CRUD actions for each "Entryable" while allowing customization as needed.

This PR aims to drastically improve the account entry editing experience. The current state of the app works as-is, but is very cumbersome in some areas. Current issues include: - Drawer editors closing while editing - Synced data not updating immediately in the UI - Minimal feedback to the user when account data is syncing in the background - Static entry info not updating as the user edits the form below it Furthermore, there was a ton of code duplication across the entry controllers (valuation, transaction, trade) that has been consolidated to the `EntryableResource` concern, which follows a similar pattern to the `AccountableResource` concern introduced in #1406. This provides default implementations for all CRUD actions for each "Entryable" while allowing customization as needed.

zachgoll (Migrated from github.com) reviewed 2024-11-27 11:19:39 +08:00

app/javascript/application.js

						
				@@ -4,0 +4,4 @@

				Turbo.StreamActions.redirect = function () {

				  Turbo.visit(this.target);

				};

zachgoll (Migrated from github.com) commented

2024-11-27 11:18:33 +08:00

Custom stream action that can be used to trigger a "refresh" to the page after a successful form submission. This is helpful because many of our forms are rendered in modals, which means for validations/errors, we need to leverage Turbo frames, but for successful submissions, we generally want a full refresh. Since Turbo doesn't provide an easy native way to handle this behavior, this provides a low-overhead, simple workaround:

redirect_target_url = request.referer || account_path(@entry.account)
        format.turbo_stream { render turbo_stream: turbo_stream.action(:redirect, redirect_target_url) }

Custom stream action that can be used to trigger a "refresh" to the page after a successful form submission. This is helpful because many of our forms are rendered in modals, which means for validations/errors, we need to leverage Turbo frames, but for successful submissions, we generally want a full refresh. Since Turbo doesn't provide an easy native way to handle this behavior, this provides a low-overhead, simple workaround: ```ruby redirect_target_url = request.referer || account_path(@entry.account) format.turbo_stream { render turbo_stream: turbo_stream.action(:redirect, redirect_target_url) } ```

app/javascript/controllers/application.js

zachgoll (Migrated from github.com) commented

2024-11-27 11:16:05 +08:00

setConfirmMethod will soon be deprecated

`setConfirmMethod` will soon be deprecated

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#1506