Budgeting V1 #1609

This seems to have broken the transfer functionality automatically applying the Payment category since the first instance is an Accountable of type Loan whereas the credit card one is CreditCard.

What was the idea behind adding this method? <img width="837" alt="Screenshot 2025-02-09 at 10 28 41 PM" src="https://github.com/user-attachments/assets/317c3b77-4468-4bee-a1eb-c83431a72c8e" /> This seems to have broken the transfer functionality automatically applying the Payment category since the first instance is an `Accountable` of type `Loan` whereas the credit card one is `CreditCard`.

zachgoll (Migrated from github.com) reviewed 2025-02-11 01:28:14 +08:00

app/models/transfer.rb

zachgoll (Migrated from github.com) commented

2025-02-11 01:28:14 +08:00

The idea here is that a payment to a Credit Card account is not categorizable, so we prevent it by adding the Payment label (which cannot be modified).

A credit card payment is not an expense (all of the transactions on the credit card account are the expenses), while a payment to a loan account would be considered an expense because there are no corresponding transactions being generated on the loan itself.

This is aimed to increase the accuracy of budgeting.

The idea here is that a payment to a Credit Card account is not categorizable, so we prevent it by adding the Payment label (which cannot be modified). A credit card payment is not an expense (all of the transactions on the credit card account are the expenses), while a payment to a loan account would be considered an expense because there are no corresponding transactions being generated on the loan itself. This is aimed to increase the accuracy of budgeting.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#1609