Reuse Correct Expense Total Calculation #1699

Merged

JLambertazzo merged 1 commits from fix/1663-consistent-expense-totals into main 2025-01-27 22:29:50 +08:00

Conversation 1 Commits 1 Files Changed 1 +1 -1

JLambertazzo commented 2025-01-27 01:51:15 +08:00 (Migrated from github.com)

Copy Link

fixes #1663

Root Cause:

• "Spent" and "Expenses" values on the budget page are being calculated by different functions

• The value under "Spent" is calculated with budget.actual_spending, which does not include Uncategorized spending

  • in #1663, notice that 62% of the $3007 is missing
  • was able to recreate this locally
    

• This is because Uncategorized category is not present on the budget_categories array in the budget class
  

Proposed Fix:

• Reuse expense_categories_with_totals.total_money which already calculates monthly expense totals, including Uncategorized spending
• Convert Money to amount to stay consistent with expected return type of actual_spending

Alternatively

Could fix by explicit inclusion of uncategorized expenses in actual_spending, but expense_categories_with_totals.total_money already calculates the desired value, and from the issue it seems we do expect the results to be the same, so I implemented the proposal above instead in this PR.

Results

After implementing the fix, the totals are consistent

fixes #1663 ## Root Cause: * "Spent" and "Expenses" values on the budget page are being calculated by different functions * The value under "Spent" is calculated with `budget.actual_spending`, which does not include Uncategorized spending * in #1663, notice that `62%` of the `$3007` is missing * was able to recreate this locally  * This is because Uncategorized category is not present on the `budget_categories` array in the `budget` class  ## Proposed Fix: * Reuse `expense_categories_with_totals.total_money` which already calculates monthly expense totals, including Uncategorized spending * Convert `Money` to `amount` to stay consistent with expected return type of `actual_spending` ### Alternatively Could fix by explicit inclusion of uncategorized expenses in `actual_spending`, but `expense_categories_with_totals.total_money` already calculates the desired value, and from the issue it seems we do expect the results to be the same, so I implemented the proposal above instead in this PR. ## Results After implementing the fix, the totals are consistent 

zachgoll (Migrated from github.com) approved these changes 2025-01-27 22:29:42 +08:00

zachgoll (Migrated from github.com) left a comment

Copy Link

Nice, thanks for tracking this down! I think your chosen solution makes sense here.

Nice, thanks for tracking this down! I think your chosen solution makes sense here.

Sign in to join this conversation.

Reviewers

No Reviewers

zachgoll

Labels

Clear labels

📆 Planned

Not ready to be worked on yet, but planned for future

💻 Self Hosted only

Issues pertaining to self-hosted versions of Maybe

⚙️ Config

ℹ️ Needs info

Further information is requested

📱 Mobile

Bugs exclusively happening on mobile devices

1️⃣ High Priority

High priority issues will be worked on next

🚨 Urgent

Issues that are urgent for app functionality

3️⃣ Low priority

Contributions accepted, but Maybe team will not be working on this in the near term

2️⃣ Medium Priority

Community contributions accepted, Maybe team only works on if there are no high priority items open

⚡ Performance

Performance issues to address

🎨 UI / UX

Issues related to UI / UX interactions and design.

💎 Bounty

💰 Rewarded

📊 Data issue

Issues where the app functionally works, but the data is missing or inaccurate.

🙋 Bounty claim

$1.5K

Community

This is a great issue for community members to work on

dependencies

Pull requests that update a dependency file

Design

Hosted only

Hosted app only

Required self hoster data migration

Self hosters must run data migrations to resolve this issue

ruby

Pull requests that update Ruby code

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

gavin

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#1699