gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

fix: improve CSV number format handling for non-USD currencies #1820

Closed
onyedikachi-david wants to merge 1 commits from fix/csv-number-format-1713 into main
pull from: fix/csv-number-format-1713
merge into: gavin:main
Conversation 1 Commits 1 Files Changed 8 +169 -4
onyedikachi-david commented 2025-02-07 14:09:01 +08:00 (Migrated from github.com)
Copy Link

https://github.com/user-attachments/assets/23433056-89fa-4327-a81b-5468b8ce0efa

Fixes: #1713
/claim #1713

Solution

Implemented a more robust number sanitization system that:

  1. Added support for multiple number formats:

    • US/UK/Asia (1,234.56)
    • European (1.234,56)
    • French/Scandinavian (1 234,56)
    • Zero-decimal currencies (1,234)

  2. Enhanced the sanitize_number method to:

    • Handle different decimal separators and thousand delimiters
    • Preserve the correct numerical value regardless of format
    • Return empty string for non-numeric input
    • Handle edge cases like leading/trailing decimals

  3. Added comprehensive tests covering:

    • All supported number formats
    • Currency symbols
    • Negative numbers
    • Edge cases (nil, empty string, non-numeric input)
    • Multiple decimal points
    • Leading/trailing zeros

Testing

Added a new test file test/models/import/number_sanitization_test.rb with 36 assertions covering:

https://github.com/user-attachments/assets/23433056-89fa-4327-a81b-5468b8ce0efa Fixes: #1713 /claim #1713 ## Solution Implemented a more robust number sanitization system that: 1. Added support for multiple number formats: - US/UK/Asia (1,234.56) - European (1.234,56) - French/Scandinavian (1 234,56) - Zero-decimal currencies (1,234) 2. Enhanced the `sanitize_number` method to: - Handle different decimal separators and thousand delimiters - Preserve the correct numerical value regardless of format - Return empty string for non-numeric input - Handle edge cases like leading/trailing decimals 3. Added comprehensive tests covering: - All supported number formats - Currency symbols - Negative numbers - Edge cases (nil, empty string, non-numeric input) - Multiple decimal points - Leading/trailing zeros ## Testing Added a new test file `test/models/import/number_sanitization_test.rb` with 36 assertions covering:
ianmartorell commented 2025-02-12 03:10:07 +08:00 (Migrated from github.com)
Copy Link

I'm testing out the csv import feature and the amount format doesn't work, would this fix it?

I'm selecting the format 1.234,56 but the data is parsed as if I had selected 1,234.56. Going back to the previous step shows the wrong amount format selected.

https://github.com/user-attachments/assets/79d7330c-a571-4151-a4b7-263c8712d855

I'm testing out the csv import feature and the amount format doesn't work, would this fix it? I'm selecting the format 1.234,56 but the data is parsed as if I had selected 1,234.56. Going back to the previous step shows the wrong amount format selected. https://github.com/user-attachments/assets/79d7330c-a571-4151-a4b7-263c8712d855

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label 🙋 Bounty claim
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#1820
Delete Branch "fix/csv-number-format-1713"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?