New Design System + Codebase Refresh #1823

2025-02-07T22:06:03+08:00

zachgoll commented

2025-02-07 22:06:03 +08:00

(Migrated from github.com)

Fixes #1848, Fixes #1836, Fixes #1651, Fixes #1330, Fixes #1670, Fixes #1530

Since the very first 0.1.0-alpha.1 release, we've been moving quickly to add new features to the Maybe app. In doing so, some parts of the codebase have become outdated, unnecessary, or overly-complex as a natural result of this feature prioritization.

Now that "core" Maybe is complete, we're moving into a second phase of development where we'll be working hard to improve the accuracy of existing features and build additional features on top of "core". This PR is a quick overhaul of the existing codebase aimed to:

Establish the brand new and simplified dashboard view (pictured above)
Establish and move towards the conventions introduced in #1788
Consolidate layouts and improve the performance of layout queries
Organize the core models of the Maybe domain (i.e. Account::Entry, Account::Transaction, etc.) and break out specific traits of each model into dedicated concerns for better readability
Remove stale / dead code from codebase
Remove overly complex code paths in favor of simpler ones

Fixes #1848, Fixes #1836, Fixes #1651, Fixes #1330, Fixes #1670, Fixes #1530 ![CleanShot 2025-02-12 at 11 35 00](https://github.com/user-attachments/assets/7199ddbd-4163-4020-98f0-17862da4aea2) Since the very first `0.1.0-alpha.1` release, we've been moving quickly to add new features to the Maybe app. In doing so, some parts of the codebase have become outdated, unnecessary, or overly-complex as a natural result of this feature prioritization. Now that "core" Maybe is complete, we're moving into a second phase of development where we'll be working hard to improve the accuracy of existing features and build additional features on top of "core". This PR is a quick overhaul of the existing codebase aimed to: - Establish the brand new and simplified dashboard view (pictured above) - Establish and move towards the conventions introduced in #1788 - Consolidate layouts and improve the performance of layout queries - Organize the core models of the Maybe domain (i.e. `Account::Entry`, `Account::Transaction`, etc.) and break out specific traits of each model into dedicated concerns for better readability - Remove stale / dead code from codebase - Remove overly complex code paths in favor of simpler ones

nikhilbadyal commented

2025-02-18 15:01:53 +08:00

(Migrated from github.com)

Showing wrong currency in the group sum. It's showing $ , it should be ₹

<img width="270" alt="image" src="https://github.com/user-attachments/assets/afe3398e-f014-414c-b1e4-6c4064022dd5" /> Showing wrong currency in the group sum. It's showing $ , it should be ₹

👀 1

nikhilbadyal commented

2025-02-18 15:09:50 +08:00

(Migrated from github.com)

Same issue in the tooltip.

<img width="475" alt="image" src="https://github.com/user-attachments/assets/3d14db45-0b49-4093-a422-ede0f2b40b86" /> Same issue in the tooltip.

👀 1

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#1823