gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Feature: Mobile responsiveness #2081

Closed
LEstradioto wants to merge 29 commits from mobile-responsiveness into main
pull from: mobile-responsiveness
merge into: gavin:main
Conversation 7 Commits 29 Files Changed 115 +1405 -715
LEstradioto commented 2025-04-11 13:29:16 +08:00 (Migrated from github.com)
Copy Link

/claim #2077

Hi, Im working on this, opening as draft, as it will have lots of changing.

SOME NOTES

  • Some texts are not the same from Current Design and Figma. So, Ive decided on my own between the options. If needed I could just change it.
  • I pointed this Help Button on mobile sidebar to Contact (intercom)

image

  • Figma presents an Abbreviated display on Assets money. Like the image:

image

Perhaps this should be implemented in another PR. Because it should handle i18n/intl properly, for Totals like 1.5B, 100M or 100K. For now, I just displayed without abbrev.

  • Implemented the abbreviation system (but just like the current format method, not with extensive i18n support)

  • I couldnt see some features, like “Export transactions”, “Download a CSV example?” (at import view), “That AI thing on CSV” (at import view). So I just ignored those.

  • Download CSV sample is implemented.

  • Could implement Export and AI csv helper, but... since this will have a lot of changing, and breaking tests probably. Better do on another PR. Just let me know if you need it in this scope.

I will keep a TODO to stay organized:

  • Finished SIGN IN/SIGN UP, ONBOARDING, HOME, Notifications, Sidebar – Accounts, ADD ACCOUNT FLOW, Transactions VIEW + Transaction detail view + New transaction, Import transactions, Budgeting view, Settings view
  • Assistant Views
  • Shared (Activity / Overview views)
  • Add a Sign in / Sign up switcher at mobile
/claim #2077 Hi, Im working on this, ~~opening as draft, as it will have lots of changing.~~ --- SOME NOTES - Some texts are not the same from Current Design and Figma. So, Ive decided on my own between the options. If needed I could just change it. - I pointed this Help Button on mobile sidebar to Contact (intercom) ![image](https://github.com/user-attachments/assets/21ea4766-187d-49c7-a6e4-179de9525aae) - ~~Figma presents an Abbreviated display on Assets money. Like the image:~~ ![image](https://github.com/user-attachments/assets/4cd55ce1-72ae-4f67-90ae-3a6d3a29cb38) ~~Perhaps this should be implemented in another PR. Because it should handle i18n/intl properly, for Totals like 1.5B, 100M or 100K. For now, I just displayed without abbrev.~~ - Implemented the abbreviation system (but just like the current format method, not with extensive i18n support) - I couldnt see some features, like “Export transactions”, ~~“Download a CSV example?” (at import view)~~, “That AI thing on CSV” (at import view). ~~So I just ignored those.~~ - Download CSV sample is implemented. - Could implement Export and AI csv helper, but... since this will have a lot of changing, and breaking tests probably. Better do on another PR. Just let me know if you need it in this scope. --- I will keep a TODO to stay organized: - [x] Finished SIGN IN/SIGN UP, ONBOARDING, HOME, Notifications, Sidebar – Accounts, ADD ACCOUNT FLOW, Transactions VIEW + Transaction detail view + New transaction, Import transactions, Budgeting view, Settings view - [x] Assistant Views - [x] Shared (Activity / Overview views) - [x] Add a Sign in / Sign up switcher at mobile
LEstradioto commented 2025-04-12 11:19:25 +08:00 (Migrated from github.com)
Copy Link

Hi there. Ive finished.

There is a lot to show, but here is a video showcasing everything.

https://github.com/user-attachments/assets/f3d75842-6150-42d0-a556-0c121bf69814

Hi there. Ive finished. There is a lot to show, but here is a video showcasing everything. https://github.com/user-attachments/assets/f3d75842-6150-42d0-a556-0c121bf69814
LEstradioto commented 2025-04-12 11:22:47 +08:00 (Migrated from github.com)
Copy Link

@Shpigford I appreciate a review on this too!

@Shpigford I appreciate a review on this too!
Shpigford commented 2025-04-18 21:47:32 +08:00 (Migrated from github.com)
Copy Link

Thank you for the work you started on this! Means a lot that you took the time and effort on it. We ultimately moved forward and merged #2092, but I'll be sending over a tip via Algora.

Thank you for the work you started on this! Means a lot that you took the time and effort on it. We ultimately moved forward and merged #2092, but I'll be sending over a tip via Algora.
Shpigford commented 2025-04-18 21:47:37 +08:00 (Migrated from github.com)
Copy Link

/tip $250

/tip $250
algora-pbc[bot] commented 2025-04-18 21:47:44 +08:00 (Migrated from github.com)
Copy Link

@LEstradioto: You've been awarded a $250 by Maybe! 👉 Complete your Algora onboarding to collect the tip.

@LEstradioto: You've been awarded a **$250** by **Maybe**! 👉 [Complete your Algora onboarding](https://algora.io/onboarding/dev) to collect the tip.
LEstradioto commented 2025-04-18 22:15:11 +08:00 (Migrated from github.com)
Copy Link

Thanks for the appreciation and the generous tip!

I have great admiration for @neo773's skills. With all due respect, I was really confused about the Bounty terms this time. At the time, #2092 was not completed despite being marked as "Ready for review". I had the option to transition my submission from Draft to Ready prior to that pull request, but refrained from doing so as it was not yet ready, similar to #2092. And I feel I just lose the Bounty because that.

Here is some topics that are added on this PR, I think would be benefical for the app anyways:

  • password validations (at model)
  • feature: money abbreviation
  • feature: filtering when adding account
  • bug fix: notifications with donut are correctly cleared (maybe related with #2015)
  • mobile menu smoothly transition when horizontal scrolls

Do you want me to separate those in another PR ?

Thanks for the appreciation and the generous tip! I have great admiration for @neo773's skills. With all due respect, I was really confused about the Bounty terms this time. At the time, #2092 was not completed despite being marked as "Ready for review". I had the option to transition my submission from Draft to Ready prior to that pull request, but refrained from doing so as it was not yet ready, similar to #2092. And I feel I just lose the Bounty because that. Here is some topics that are added on this PR, I think would be benefical for the app anyways: - password validations (at model) - feature: money abbreviation - feature: filtering when adding account - bug fix: notifications with donut are correctly cleared (maybe related with #2015) - mobile menu smoothly transition when horizontal scrolls Do you want me to separate those in another PR ?
algora-pbc[bot] commented 2025-05-20 17:51:12 +08:00 (Migrated from github.com)
Copy Link

🎉🎈 @LEstradioto has been awarded $250 by Maybe! 🎈🎊

🎉🎈 @LEstradioto has been awarded **$250** by **Maybe**! 🎈🎊

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label 💰 Rewarded 🙋 Bounty claim
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#2081
Delete Branch "mobile-responsiveness"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?