gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Improve account sync performance, handle concurrent market data syncing #2236

Merged
zachgoll merged 30 commits from zachgoll/plaid-domain-improvements into main 2025-05-15 22:19:57 +08:00
Conversation 0 Commits 30 Files Changed 97 +1837 -949
zachgoll commented 2025-05-12 22:42:16 +08:00 (Migrated from github.com)
Copy Link

The major goal of this PR is twofold:

  1. Offload market data syncing to a daily cron to reduce the number of contentious upserts happening during account syncs
  2. Improve the overall sync process and UI states

Sync UI states

We have removed the manual "sync" button on each account because with the right orchestration of syncs, these should never be needed. There are 3 major sync types:

  • Family sync
  • PlaidItem sync
  • Account sync

And there are a few important sync triggers:

Event Triggers
Add account Sync account
Add PlaidItem Sync item, all child accounts
Update an account entry Sync account
Daily auto-sync Sync family

Previously, the UI states for these was a bit scattered. This PR introduces some more granular UI updates to avoid disturbing the user with unnecessary sync refreshes.

  • Account Sync
    • Start
      • Sidebar shows account loading
      • Account graph shows loading
    • End
      • Sidebar stops loading
      • Account graph refreshes
  • PlaidItem Sync
    • Start
      • Sidebar shows all Plaid accounts loading
      • All Plaid account charts show as loading
    • End
      • Sidebar accounts stop loading 1 by 1 as they finish syncing
      • All Plaid account charts refresh 1 by 1 as they finish syncing
  • Family Sync
    • Start
      • Net worth graph loads
      • Balance sheet on dashboard shows loading states
    • End
      • Net worth graph refreshes
      • Balance sheet shows
      • Sidebar stops loading
The major goal of this PR is twofold: 1. Offload market data syncing to a daily cron to reduce the number of contentious upserts happening during account syncs 2. Improve the overall sync process and UI states **Sync UI states** We have removed the manual "sync" button on each account because with the right orchestration of syncs, these should never be needed. There are 3 major sync types: - Family sync - PlaidItem sync - Account sync And there are a few important sync triggers: | Event | Triggers | | --- | ---| | Add account | Sync account | | Add PlaidItem | Sync item, all child accounts | | Update an account entry | Sync account| | Daily auto-sync | Sync family | Previously, the UI states for these was a bit scattered. This PR introduces some more granular UI updates to avoid disturbing the user with unnecessary sync refreshes. - Account Sync - Start - Sidebar shows account loading - Account graph shows loading - End - Sidebar stops loading - Account graph refreshes - PlaidItem Sync - Start - Sidebar shows all Plaid accounts loading - All Plaid account charts show as loading - End - Sidebar accounts stop loading 1 by 1 as they finish syncing - All Plaid account charts refresh 1 by 1 as they finish syncing - Family Sync - Start - Net worth graph loads - Balance sheet on dashboard shows loading states - End - Net worth graph refreshes - Balance sheet shows - Sidebar stops loading
🎉 3
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#2236
Delete Branch "zachgoll/plaid-domain-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?