Fix/design system violations #2422

2025-06-29T18:55:27+08:00

EranAvidor commented

2025-06-29 18:55:27 +08:00

(Migrated from github.com)

Fix Design System Violations

Summary

This PR addresses critical UI/UX and frontend issues by replacing hardcoded color classes with proper design system tokens throughout the codebase.

Changes

10 commits, each addressing a single design system violation
Replaced hardcoded colors (text-white, bg-white, border-gray-*) with design system tokens (fg-inverse, bg-container, border-secondary, etc.)
All changes follow repository conventions and maintain existing functionality

Files Modified

app/views/shared/notifications/_notice.html.erb
app/views/shared/notifications/_cta.html.erb
app/views/shared/_text_tooltip.erb
app/views/invitations/new.html.erb
app/views/chats/_ai_consent.html.erb
app/views/pages/changelog.html.erb
app/views/investments/_value_tooltip.html.erb
app/views/holdings/_missing_price_tooltip.html.erb
app/views/settings/profiles/show.html.erb
app/views/settings/hostings/_danger_zone_settings.html.erb

Compliance

✅ Uses proper design system tokens
✅ Maintains semantic HTML
✅ Uses icon helper correctly (no direct lucide_icon calls)
✅ No breaking changes or logic modifications

Testing

Changes are low-risk CSS class replacements
No functional modifications
All changes follow established patterns and conventions

Addresses UI/UX & Frontend Issues identified in recent commit analysis

# Fix Design System Violations ## Summary This PR addresses critical UI/UX and frontend issues by replacing hardcoded color classes with proper design system tokens throughout the codebase. ## Changes - **10 commits**, each addressing a single design system violation - Replaced hardcoded colors (`text-white`, `bg-white`, `border-gray-*`) with design system tokens (`fg-inverse`, `bg-container`, `border-secondary`, etc.) - All changes follow repository conventions and maintain existing functionality ## Files Modified - `app/views/shared/notifications/_notice.html.erb` - `app/views/shared/notifications/_cta.html.erb` - `app/views/shared/_text_tooltip.erb` - `app/views/invitations/new.html.erb` - `app/views/chats/_ai_consent.html.erb` - `app/views/pages/changelog.html.erb` - `app/views/investments/_value_tooltip.html.erb` - `app/views/holdings/_missing_price_tooltip.html.erb` - `app/views/settings/profiles/show.html.erb` - `app/views/settings/hostings/_danger_zone_settings.html.erb` ## Compliance ✅ Uses proper design system tokens ✅ Maintains semantic HTML ✅ Uses `icon` helper correctly (no direct `lucide_icon` calls) ✅ No breaking changes or logic modifications ## Testing - Changes are low-risk CSS class replacements - No functional modifications - All changes follow established patterns and conventions ## Related Addresses UI/UX & Frontend Issues identified in recent commit analysis

zachgoll (Migrated from github.com) approved these changes 2025-06-30 21:33:17 +08:00

zachgoll (Migrated from github.com) left a comment

Awesome! Thank you for these updates and for the clear PR description. Makes it easy to review 💯

EranAvidor commented

2025-07-01 15:53:54 +08:00

(Migrated from github.com)

@zachgoll, thanks for your feedback.
Would you like me to rebase the branch so we can merge it to master?

@zachgoll, thanks for your feedback. Would you like me to rebase the branch so we can merge it to `master`?

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gavin/maybe#2422