gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

fix: support comma-separated currency input for budgeted_spending #2500 #2516

Closed
Mohan82git wants to merge 1 commits from comma-fails-bug into main
pull from: comma-fails-bug
merge into: gavin:main
Conversation 2 Commits 1 Files Changed 1 +1 -1
Mohan82git commented 2025-07-24 18:28:46 +08:00 (Migrated from github.com)
Copy Link

What this does

This pull request fixes an issue where users would see a validation error (“Enter a number”) when trying to input currency values like 1,234.56 in the budget form. The problem was that Rails didn’t recognize numbers with commas as valid.

To solve this, we now sanitize the budgeted_spending input by removing commas before it's processed — so users can enter currency in a more natural way without running into errors.

What changed

  • Updated the budget_category_params method in budget_categories_controller.rb to strip commas from the budgeted_spending value.

Related issue

Fixes #2500

### What this does This pull request fixes an issue where users would see a validation error (“Enter a number”) when trying to input currency values like 1,234.56 in the budget form. The problem was that Rails didn’t recognize numbers with commas as valid. To solve this, we now sanitize the budgeted_spending input by removing commas before it's processed — so users can enter currency in a more natural way without running into errors. ### What changed - Updated the budget_category_params method in budget_categories_controller.rb to strip commas from the budgeted_spending value. ### Related issue Fixes #2500
jjmata commented 2025-07-26 00:59:52 +08:00 (Migrated from github.com)
Copy Link

This repo is no longer maintained. Want to submit your PR here instead, @Mohan82git? 🙏

This repo is [no longer maintained](https://github.com/maybe-finance/maybe/blob/main/README.md?plain=1#L15). Want to submit your PR [here](https://github.com/we-promise/sure) instead, @Mohan82git? 🙏
Mohan82git commented 2025-07-26 12:18:46 +08:00 (Migrated from github.com)
Copy Link

This repo is no longer maintained. Want to submit your PR here instead, @Mohan82git? 🙏

There is no such issue there so i guess that bug is fixed

> This repo is [no longer maintained](https://github.com/maybe-finance/maybe/blob/main/README.md?plain=1#L15). Want to submit your PR [here](https://github.com/we-promise/sure) instead, @Mohan82git? 🙏 There is no such issue there so i guess that bug is fixed

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#2516
Delete Branch "comma-fails-bug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?