gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

change server listening address to global #342

Merged
lcx merged 1 commits from fix_procfile into main 2024-02-07 09:48:15 +08:00
Conversation 4 Commits 1 Files Changed 1 +1 -1
lcx commented 2024-02-07 07:08:55 +08:00 (Migrated from github.com)
Copy Link

listen to 0.0.0.0 instead of just local interface so it can work in Docker (and herby in devcontainers) refs #340
Credits go to @robzolkos

listen to 0.0.0.0 instead of just local interface so it can work in Docker (and herby in devcontainers) refs #340 Credits go to @robzolkos
robzolkos commented 2024-02-07 07:10:08 +08:00 (Migrated from github.com)
Copy Link

Im concerned this will affect non devcontainer users. Will need to be checked by someone who runs the app on metal.

Im concerned this will affect non devcontainer users. Will need to be checked by someone who runs the app on metal.
jespr commented 2024-02-07 07:40:49 +08:00 (Migrated from github.com)
Copy Link

This works fine for me running it locally on my Macbook Pro (non-docker)

This works fine for me running it locally on my Macbook Pro (non-docker)
❤️ 1
robzolkos (Migrated from github.com) approved these changes 2024-02-07 07:49:48 +08:00
lcx commented 2024-02-07 16:16:56 +08:00 (Migrated from github.com)
Copy Link

I indeed haven't started it without devcontainer, was already midnight when I made the PR. But listening on 0.0.0.0 still allows you to connect via 127.0.0.1 should be no issue that's why I pushed without testing without devcontainer.

I indeed haven't started it without devcontainer, was already midnight when I made the PR. But listening on 0.0.0.0 still allows you to connect via 127.0.0.1 should be no issue that's why I pushed without testing without devcontainer.
👍 1
Sign in to join this conversation.
Reviewers
No Reviewers
robzolkos
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#342
Delete Branch "fix_procfile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?