gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

Build out account sidebar #391

Merged
JoshAntBrown merged 4 commits from feature/account-sidebar into main 2024-02-09 05:46:27 +08:00
Conversation 8 Commits 4 Files Changed 4 +42 -18
JoshAntBrown commented 2024-02-09 05:10:17 +08:00 (Migrated from github.com)
Copy Link

I've put this together for the account sidebar. Should be a near 1 to 1 match with Figma since I checked all the dimensions to the tailwind ones or used a custom number where required.

I'm not particularly happy about the way I've queried the accounts within the partial right now, it might be nicer if we could just do type.all and have the model scoped by the Current.family automatically but that's a wider problem than the scope of this issue.

/claim #386

I've put this together for the account sidebar. Should be a near 1 to 1 match with Figma since I checked all the dimensions to the tailwind ones or used a custom number where required. I'm not particularly happy about the way I've queried the accounts within the partial right now, it might be nicer if we could just do `type.all` and have the model scoped by the Current.family automatically but that's a wider problem than the scope of this issue. /claim #386
algora-pbc[bot] commented 2024-02-09 05:10:23 +08:00 (Migrated from github.com)
Copy Link

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay.

💵 To receive payouts, [sign up on Algora](https://console.algora.io/auth/signup), [link your Github account](https://console.algora.io/onboarding/solver) and [connect with Stripe/Alipay](https://console.algora.io/onboarding/solver).
robzolkos (Migrated from github.com) reviewed 2024-02-09 05:12:46 +08:00
app/views/accounts/_account_list.html.erb
@@ -0,0 +1,30 @@
<%# locals: (type:) -%>
robzolkos (Migrated from github.com) commented 2024-02-09 05:12:46 +08:00
Copy Link

@JoshAntBrown any thoughts on using summary/detail element for this?

@JoshAntBrown any thoughts on using summary/detail element for this?
JoshAntBrown (Migrated from github.com) reviewed 2024-02-09 05:14:04 +08:00
app/views/accounts/_account_list.html.erb
@@ -0,0 +1,30 @@
<%# locals: (type:) -%>
JoshAntBrown (Migrated from github.com) commented 2024-02-09 05:14:04 +08:00
Copy Link

Good call, will refactor, wanted to get a first version out

Good call, will refactor, wanted to get a first version out
JoshAntBrown (Migrated from github.com) reviewed 2024-02-09 05:37:56 +08:00
app/views/accounts/_account_list.html.erb
@@ -0,0 +1,30 @@
<%# locals: (type:) -%>
JoshAntBrown (Migrated from github.com) commented 2024-02-09 05:37:56 +08:00
Copy Link

Much better with the detail element, no need for the stimulus controller, and toggling between the icons feels more robust being based on the state of the dialog. Thanks!

Much better with the detail element, no need for the stimulus controller, and toggling between the icons feels more robust being based on the state of the dialog. Thanks!
Shpigford commented 2024-02-09 05:38:40 +08:00 (Migrated from github.com)
Copy Link

@JoshAntBrown Would you mind adding a GIF or short video showing the functionality? Just a super quick little thing to show that it's functioning. 🙂 Much easier to give feedback on that side of things without pulling the code down.

@JoshAntBrown Would you mind adding a GIF or short video showing the functionality? Just a super quick little thing to show that it's functioning. 🙂 Much easier to give feedback on that side of things without pulling the code down.
robzolkos (Migrated from github.com) reviewed 2024-02-09 05:39:43 +08:00
app/views/accounts/_account_list.html.erb
@@ -0,0 +1,30 @@
<%# locals: (type:) -%>
robzolkos (Migrated from github.com) commented 2024-02-09 05:39:43 +08:00
Copy Link

Is this data-action still needed?

Is this data-action still needed?
JoshAntBrown commented 2024-02-09 05:45:32 +08:00 (Migrated from github.com)
Copy Link

@JoshAntBrown Would you mind adding a GIF or short video showing the functionality? Just a super quick little thing to show that it's functioning. 🙂 Much easier to give feedback on that side of things without pulling the code down.

Ah of course, here it is:

https://github.com/maybe-finance/maybe/assets/1793797/79ebdf02-01c6-4803-81f7-188004f32eb6

Currently only have bank accounts since the new account flow seems to be hardcoded to depository accounts, but it should work with any account.

> @JoshAntBrown Would you mind adding a GIF or short video showing the functionality? Just a super quick little thing to show that it's functioning. 🙂 Much easier to give feedback on that side of things without pulling the code down. Ah of course, here it is: https://github.com/maybe-finance/maybe/assets/1793797/79ebdf02-01c6-4803-81f7-188004f32eb6 Currently only have bank accounts since the new account flow seems to be hardcoded to depository accounts, but it should work with any account.
Shpigford commented 2024-02-09 05:46:20 +08:00 (Migrated from github.com)
Copy Link

@JoshAntBrown Amazing! Looks good to me. Merging now.

@JoshAntBrown Amazing! Looks good to me. Merging now.
Sign in to join this conversation.
Reviewers
No Reviewers
JoshAntBrown
robzolkos
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label 🙋 Bounty claim
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#391
Delete Branch "feature/account-sidebar"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?