gavin/maybe
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 28 Wiki Activity

feat: add nav_link method to ApplicationHelper #431

Closed
ezhil56x wants to merge 4 commits from menu-helper into main
pull from: menu-helper
merge into: gavin:main
Conversation 7 Commits 4 Files Changed 2 +15 -18
ezhil56x commented 2024-02-11 12:19:28 +08:00 (Migrated from github.com)
Copy Link

Changes

  • Added the nav_link method to ApplicationHelper.
  • Updated the nav_link method to include hover and selected states.

/claim #428

### Changes - Added the nav_link method to ApplicationHelper. - Updated the nav_link method to include hover and selected states. /claim #428
ezhil56x commented 2024-02-11 13:09:50 +08:00 (Migrated from github.com)
Copy Link

@Shpigford Can you review this PR once?

@Shpigford Can you review this PR once?
robzolkos (Migrated from github.com) reviewed 2024-02-11 14:26:08 +08:00
app/helpers/application_helper.rb
@@ -50,4 +50,16 @@ module ApplicationHelper
robzolkos (Migrated from github.com) commented 2024-02-11 14:26:08 +08:00
Copy Link

A more specific name for this particular nav link may be better in-case there are other nav related links? Perhaps main_nav_link ?

A more specific name for this particular nav link may be better in-case there are other nav related links? Perhaps `main_nav_link` ?
robzolkos (Migrated from github.com) reviewed 2024-02-11 14:39:31 +08:00
app/helpers/application_helper.rb
@@ -50,4 +50,16 @@ module ApplicationHelper
robzolkos (Migrated from github.com) commented 2024-02-11 14:39:31 +08:00
Copy Link
    classes = 'block border border-transparent rounded-xl p-2 text-sm font-medium text-gray-500 flex items-center'
    hover_classes = 'hover:bg-white hover:border-[#141414]/[0.07] hover:text-gray-900 hover:shadow-xs'
    apply_hover_classes = true unless current_page
  
    content_tag(:li) do
      link_to(path, class: class_list(classes, hover_classes: apply_hover_classes) do
```suggestion classes = 'block border border-transparent rounded-xl p-2 text-sm font-medium text-gray-500 flex items-center' hover_classes = 'hover:bg-white hover:border-[#141414]/[0.07] hover:text-gray-900 hover:shadow-xs' apply_hover_classes = true unless current_page content_tag(:li) do link_to(path, class: class_list(classes, hover_classes: apply_hover_classes) do ```
robzolkos (Migrated from github.com) reviewed 2024-02-11 14:43:02 +08:00
app/helpers/application_helper.rb
@@ -50,4 +50,16 @@ module ApplicationHelper
robzolkos (Migrated from github.com) commented 2024-02-11 14:43:02 +08:00
Copy Link

note: current_page is already passed in as a boolean so I don't think you need the current_path?(path) test again?

note: `current_page` is already passed in as a boolean so I don't think you need the `current_path?(path)` test again?
ezhil56x (Migrated from github.com) reviewed 2024-02-11 15:00:08 +08:00
app/helpers/application_helper.rb
@@ -50,4 +50,16 @@ module ApplicationHelper
ezhil56x (Migrated from github.com) commented 2024-02-11 15:00:08 +08:00
Copy Link

Done👍🏻

Done👍🏻
ezhil56x (Migrated from github.com) reviewed 2024-02-11 15:00:14 +08:00
app/helpers/application_helper.rb
@@ -50,4 +50,16 @@ module ApplicationHelper
ezhil56x (Migrated from github.com) commented 2024-02-11 15:00:14 +08:00
Copy Link

Done👍🏻

Done👍🏻
Shpigford commented 2024-02-12 02:49:30 +08:00 (Migrated from github.com)
Copy Link

Closing in favor of #435. Thank you for working on this!

Closing in favor of #435. Thank you for working on this!

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
robzolkos
ezhil56x
Labels
Clear labels
📆 Planned
Not ready to be worked on yet, but planned for future
 💻 Self Hosted only
Issues pertaining to self-hosted versions of Maybe
 ⚙️ Config
ℹ️ Needs info
Further information is requested
 📱 Mobile
Bugs exclusively happening on mobile devices
 1️⃣ High Priority
High priority issues will be worked on next
 🚨 Urgent
Issues that are urgent for app functionality
 3️⃣ Low priority
Contributions accepted, but Maybe team will not be working on this in the near term
 2️⃣ Medium Priority
Community contributions accepted, Maybe team only works on if there are no high priority items open
 ⚡ Performance
Performance issues to address
 🎨 UI / UX
Issues related to UI / UX interactions and design.
 💎 Bounty
💰 Rewarded
📊 Data issue
Issues where the app functionally works, but the data is missing or inaccurate.
 🙋 Bounty claim
$1.5K
Community
This is a great issue for community members to work on
 dependencies
Pull requests that update a dependency file
 Design
Hosted only
Hosted app only
 Required self hoster data migration
Self hosters must run data migrations to resolve this issue
 ruby
Pull requests that update Ruby code
No Label 🙋 Bounty claim
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gavin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gavin/maybe#431
Delete Branch "menu-helper"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?